Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use seq_along() instead of seq(along=) #6

Merged
merged 1 commit into from Jul 28, 2016

Conversation

Projects
None yet
2 participants
@heavywatal
Copy link
Contributor

heavywatal commented Jul 28, 2016

Summary:

seq(along=...) is replaced with seq_along(...) inR/cxxfunction.R and R/cfunction.R.

Intended Effect:

No effect on functionality is expected. seq_along() may be a bit faster. I just wanted to suppress the warning from cxxfunction() in the environment that options(warnPartialMatchArgs=TRUE) is set.

@eddelbuettel

This comment has been minimized.

Copy link
Owner

eddelbuettel commented Jul 28, 2016

Good ones. I like seq_along(...) too. The inline package has a bit of a back seat now as Rcpp Attributes is generally preferably but this is still good.

@heavywatal

This comment has been minimized.

Copy link
Contributor Author

heavywatal commented Jul 28, 2016

Oh, I didn't know that. I will suggest using Rcpp Attributes to rstan community.

@eddelbuettel eddelbuettel merged commit d9301b5 into eddelbuettel:master Jul 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

eddelbuettel added a commit that referenced this pull request Jul 28, 2016

@heavywatal heavywatal deleted the heavywatal:seq_along branch Jul 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.