Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue #17 #18

Merged
merged 2 commits into from Jun 25, 2018
Merged

fixed issue #17 #18

merged 2 commits into from Jun 25, 2018

Conversation

@markvanderloo
Copy link
Contributor

@markvanderloo markvanderloo commented Jun 25, 2018

As per the comment in #17. I think it fixes it. Not sure if it would break anything else. Output of a minimal example with letterhead seems fine.

DESCRIPTION Outdated
@@ -1,7 +1,7 @@
Package: linl
Type: Package
Title: 'linl' is not 'Letter'
Version: 0.0.2
Version: 0.0.3

This comment has been minimized.

@eddelbuettel

eddelbuettel Jun 25, 2018
Owner

I tend to call these 0.0.2.1 before making it final for CRAN but details...

This comment has been minimized.

@@ -225,7 +225,7 @@
$endif$

$if(letterhead)$
\usepackage[dvipsnames]{color}
%\usepackage[dvipsnames]{color}

This comment has been minimized.

@eddelbuettel

eddelbuettel Jun 25, 2018
Owner

May as well remove it.

This comment has been minimized.

NEWS Outdated
version 0.0.3
- fixed LaTeX problem caused by double loading of \usepackage{color} with different
options. Occurred when specifying 'letterhead' while 'colorlinks' was 'false'.

This comment has been minimized.

@eddelbuettel

eddelbuettel Jun 25, 2018
Owner

We have an existing file inst/NEWS.Rd -- can you add there instead please?

This comment has been minimized.

@eddelbuettel eddelbuettel merged commit 4892e7a into eddelbuettel:master Jun 25, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants