Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/travis via docker #21

Merged
merged 4 commits into from Dec 16, 2018

Conversation

@eddelbuettel
Copy link
Owner

eddelbuettel commented Dec 16, 2018

Seems to work just fine

@eddelbuettel eddelbuettel requested a review from aaronwolen Dec 16, 2018
@eddelbuettel eddelbuettel referenced this pull request Dec 16, 2018
Copy link
Collaborator

aaronwolen left a comment

Looks great! I'm really liking this approach.

Co-Authored-By: eddelbuettel <edd@debian.org>
@eddelbuettel

This comment has been minimized.

Copy link
Owner Author

eddelbuettel commented Dec 16, 2018

Looks great! I'm really liking this approach.

Thank you! I was a little hesitant as I did not want to come across as too heavy-handed when just about everybody else uses 'default' Travis. But this does have clear advantages in my view: the portability of the Docker container widens the applicability, and as a side effect gives people the ability to deploy. (There are are downsides: if we needed new packages in the container we'd first have to commit; the cycle on that is short though as the Docker build service usually turns around within minutes.)

skip_on_cran

I totally missed that. I just used GitHub fancyness as committed your suggestion here in the GUI. I'm open -- if these are useful tests, should they not run at CRAN too? Why skip?

@eddelbuettel eddelbuettel merged commit d11f922 into master Dec 16, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@eddelbuettel eddelbuettel deleted the feature/travis_via_docker branch Dec 16, 2018
@aaronwolen

This comment has been minimized.

Copy link
Collaborator

aaronwolen commented Dec 17, 2018

I was concerned these tests might put an unnecessary burden on CRAN's build servers, especially as the number of tests start to accumulate. What do you think?

@eddelbuettel

This comment has been minimized.

Copy link
Owner Author

eddelbuettel commented Dec 17, 2018

Ah, I see -- good thinking.

But there is a protocol for this: we generally have 'one minute' (which is not too bad) and check logs report that. So I'd say for now we can turn them on. Given that you wrote them :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.