Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFeature/travis via docker #21
Conversation
|
Looks great! I'm really liking this approach. |
Co-Authored-By: eddelbuettel <edd@debian.org>
Thank you! I was a little hesitant as I did not want to come across as too heavy-handed when just about everybody else uses 'default' Travis. But this does have clear advantages in my view: the portability of the Docker container widens the applicability, and as a side effect gives people the ability to deploy. (There are are downsides: if we needed new packages in the container we'd first have to commit; the cycle on that is short though as the Docker build service usually turns around within minutes.)
I totally missed that. I just used GitHub fancyness as committed your suggestion here in the GUI. I'm open -- if these are useful tests, should they not run at CRAN too? Why skip? |
|
I was concerned these tests might put an unnecessary burden on CRAN's build servers, especially as the number of tests start to accumulate. What do you think? |
|
Ah, I see -- good thinking. But there is a protocol for this: we generally have 'one minute' (which is not too bad) and check logs report that. So I'd say for now we can turn them on. Given that you wrote them :) |
Seems to work just fine