Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upLetterfoot #23
Letterfoot #23
Conversation
| @@ -0,0 +1,13 @@ | |||
| # remotes::install_github("coolbutuseless/minipdf") | |||
| library(minipdf) | |||
eddelbuettel
Oct 17, 2019
Owner
Can we do without additional depends? I.e. place a pre-made pdf somewhere -- ie in vignettes/examples and don't create it on the fly.
Can we do without additional depends? I.e. place a pre-made pdf somewhere -- ie in vignettes/examples and don't create it on the fly.
eddelbuettel
Oct 17, 2019
Owner
Oh, and I see you added the file, so this is "mostly" just documentation?
Oh, and I see you added the file, so this is "mostly" just documentation?
mbojan
Oct 17, 2019
Author
Contributor
Yeah, this just shows how the footer was created.
Yeah, this just shows how the footer was created.
mbojan
Oct 17, 2019
Author
Contributor
We can do without it if you want.
We can do without it if you want.
eddelbuettel
Oct 17, 2019
Owner
If R CMD check does not complain about it (and I later realized it would not as this not package code per se) then it can stay, and is in fact a nice touch documenting how you made it.
I was just being careful and there is (in my book) no upside to expanding Depends: or Imports: for pure illustrations.
If R CMD check does not complain about it (and I later realized it would not as this not package code per se) then it can stay, and is in fact a nice touch documenting how you made it.
I was just being careful and there is (in my book) no upside to expanding Depends: or Imports: for pure illustrations.
mbojan
Oct 17, 2019
Author
Contributor
OK, thanks. Sure. I myself definitely subscribe to limiting dependencies as much as possible too.
OK, thanks. Sure. I myself definitely subscribe to limiting dependencies as much as possible too.
Yes, please add that line as well. |
|
One more please: Add yourself and the changed files to |
|
Updated |
|
Just tested this out, works great! Thanks for the PR, @mbojan. |
|
Sorry, week got crazy busy. Merging now, and thanks to @aaronwolen for test driving it. |
9c399fd
into
eddelbuettel:master
This addresses #10 .
I have updated the docs and the vignette too.
BTW,
R CMD checkcomplains that it needsEncoding: UTF-8in theDESCRIPTION. May I fix this on in this PR before the (hopeful) merge?