Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letterfoot #23

Merged
merged 9 commits into from Oct 18, 2019
Merged

Letterfoot #23

merged 9 commits into from Oct 18, 2019

Conversation

@mbojan
Copy link
Contributor

@mbojan mbojan commented Oct 17, 2019

This addresses #10 .

I have updated the docs and the vignette too.

BTW, R CMD check complains that it needs Encoding: UTF-8 in the DESCRIPTION. May I fix this on in this PR before the (hopeful) merge?

@@ -0,0 +1,13 @@
# remotes::install_github("coolbutuseless/minipdf")
library(minipdf)
Copy link
Owner

@eddelbuettel eddelbuettel Oct 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do without additional depends? I.e. place a pre-made pdf somewhere -- ie in vignettes/examples and don't create it on the fly.

Copy link
Owner

@eddelbuettel eddelbuettel Oct 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and I see you added the file, so this is "mostly" just documentation?

Copy link
Contributor Author

@mbojan mbojan Oct 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this just shows how the footer was created.

Copy link
Contributor Author

@mbojan mbojan Oct 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do without it if you want.

Copy link
Owner

@eddelbuettel eddelbuettel Oct 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If R CMD check does not complain about it (and I later realized it would not as this not package code per se) then it can stay, and is in fact a nice touch documenting how you made it.

I was just being careful and there is (in my book) no upside to expanding Depends: or Imports: for pure illustrations.

Copy link
Contributor Author

@mbojan mbojan Oct 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks. Sure. I myself definitely subscribe to limiting dependencies as much as possible too.

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Oct 17, 2019

it needs Encoding: UTF-8 in the DESCRIPTION

Yes, please add that line as well.

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Oct 17, 2019

One more please: Add yourself and the changed files to ChangeLog.

@mbojan
Copy link
Contributor Author

@mbojan mbojan commented Oct 17, 2019

Updated ChangeLog. I hope it is OK. Is this some special machine-readable format?

@aaronwolen
Copy link
Collaborator

@aaronwolen aaronwolen commented Oct 17, 2019

Just tested this out, works great! Thanks for the PR, @mbojan.

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Oct 18, 2019

Sorry, week got crazy busy. Merging now, and thanks to @aaronwolen for test driving it.

@eddelbuettel eddelbuettel merged commit 9c399fd into eddelbuettel:master Oct 18, 2019
1 check passed
@mbojan mbojan deleted the letterfoot branch Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants