Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDocument letterhead side and scale options #26
Merged
Conversation
|
Is It time for a version bump? |
Guilty as charged. But the code was 'good enough' and the discussion was meandering off risking the code to be forgotten. Plus hey I had tested it
Yes. And I think I quickly roll up a release in a day or two. |
|
You are one commit behind though it says. Do you want to rebase or shall I just squash-merge? (Looks like you just didn't pull yet following the merge.) |
|
Thanks! I missed that. Just rebased so it should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Last PR was merged before I had a chance to document the new options😄 .