Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document letterhead side and scale options #26

Merged
merged 2 commits into from Oct 22, 2019
Merged

Document letterhead side and scale options #26

merged 2 commits into from Oct 22, 2019

Conversation

@aaronwolen
Copy link
Collaborator

@aaronwolen aaronwolen commented Oct 22, 2019

Last PR was merged before I had a chance to document the new options 馃槃.

@aaronwolen
Copy link
Collaborator Author

@aaronwolen aaronwolen commented Oct 22, 2019

Is It time for a version bump?

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Oct 22, 2019

Last PR was merged before I had a chance to document the new options

Guilty as charged. But the code was 'good enough' and the discussion was meandering off risking the code to be forgotten. Plus hey I had tested it 馃榾

Is It time for a version bump?

Yes. And I think I quickly roll up a release in a day or two.

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Oct 22, 2019

You are one commit behind though it says. Do you want to rebase or shall I just squash-merge?

(Looks like you just didn't pull yet following the merge.)

@aaronwolen
Copy link
Collaborator Author

@aaronwolen aaronwolen commented Oct 22, 2019

Thanks! I missed that. Just rebased so it should be good to go.

@eddelbuettel eddelbuettel merged commit 5c9954e into master Oct 22, 2019
0 of 2 checks passed
@eddelbuettel eddelbuettel deleted the update-docs branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants