Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make blockquote a default, opt-out via 'plainquote: true' #4

Merged
merged 1 commit into from Oct 19, 2017

Conversation

eddelbuettel
Copy link
Owner

No description provided.

Copy link
Collaborator

@aaronwolen aaronwolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 plainquote is a great name.

@aaronwolen
Copy link
Collaborator

aaronwolen commented Oct 19, 2017

I'm considering reimplementing blockquote using the framed package, which is a knitr dependency, so one less thing the user needs to worry about installing.

What do you think?

@eddelbuettel
Copy link
Owner Author

I am confused. How can a CTAN package be a dependency of knitr, a CRAN package.

Despite 25+ years of latex, framed was new to me. But I learned about it for pinp, and what is does in linl seems similar and "good enough". Exactly which part needs replacing? Is framed only in extended texlive (et al)?

@eddelbuettel
Copy link
Owner Author

And BTW you can merge. Esp if you approve :)

But if you'd rather discuss more that is cool too.

@aaronwolen aaronwolen merged commit 0e23150 into master Oct 19, 2017
@aaronwolen
Copy link
Collaborator

And BTW you can merge. Esp if you approve :)

Done. I wasn't sure if you wanted final cut.

I am confused. How can a CTAN package be a dependency of knitr, a CRAN package.

Ah, sorry. I worded that poorly. It's not technically a dependency: knitr uses framed to draw code blocks in PDFs, so it's a requirement to run knit2pdf(), for example. If framed is not installed on your machine knitr provides the following warning and helpfully drops a copy of framed.sty in your working directory:

Warning message:
In knitr:::test_latex_pkg("framed", system.file("misc", "framed.sty",  :
  unable to find LaTeX package 'framed'; will use a copy from knitr

So if we reimplement blockquote using framed then we can just grab knitr's copy and avoid pestering the user with a missing .sty error.

That said, both framed and mdframed are included in texlive-latex-extra, so this really only affects that small group of micromanagers (like me) who opt for texlive-core (or BasicTex) and then install other CTAN packages as needed.

@eddelbuettel
Copy link
Owner Author

Thanks for merging. I am with you on the worry about minimal versus extended LaTeX installations. But a macOS friend opening my eyes there (ie: they install even more than us) and the miktex folks add as needed.

So in sum: I think we could just leave it as is. I have 25+ years worth of latex letters, and I may have use quoting less than a handful of times in the letters. Whaddayouthink?

@aaronwolen
Copy link
Collaborator

That makes sense. Maybe I'll revisit in the future after more pressing issues are addressed.

@eddelbuettel eddelbuettel deleted the feature/default_blockquote branch October 19, 2017 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants