Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass on options post '--' to INSTALL_opts #37

Merged
merged 1 commit into from Nov 17, 2015

Conversation

@shabbychef
Copy link

@shabbychef shabbychef commented Nov 17, 2015

This will allow e.g. --with-keep.source installs.

Steven Pav
This will allow e.g. --with-keep.source installs.
@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Nov 17, 2015

Wow, did you just teach me a new (and very useful) docopt trick? This looks good, so thanks!

(Insert usual please for folks to also update ChangeLog, inst/NEWS, ... )

eddelbuettel added a commit that referenced this pull request Nov 17, 2015
pass on options post '--' to INSTALL_opts
@eddelbuettel eddelbuettel merged commit 34cd2a6 into eddelbuettel:master Nov 17, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@shabbychef
Copy link
Author

@shabbychef shabbychef commented Nov 17, 2015

You're welcome. I just learned this trick myself.
Do you want me to mod ChangeLog and so on?

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Nov 17, 2015

No worries I'll do it. Consider it a plea for next time :)

@shabbychef
Copy link
Author

@shabbychef shabbychef commented Nov 17, 2015

done.

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Nov 17, 2015

Preference for email I use? Git log used corecast.io... Prefer @gmail ?

@shabbychef
Copy link
Author

@shabbychef shabbychef commented Nov 18, 2015

oops. Yep, shabbychef at gmail. Thanks,

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Nov 18, 2015

Done too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.