Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdating vignette for installGithub.r #39
Merged
Conversation
Looks like the arguments and helper script were inappropriately copy pasted from the previous description of install.r in the file. Updated with the example at https://github.com/eddelbuettel/littler/blob/733a96ca46c1234f67ee33274f82c645ffcb5035/inst/examples/installGithub.r also included example at head of section for users not interested in details.
|
Looks good. I am between a few things right; should have a chance later to look more closely. |
|
Comparing to the script now -- good catch, and thanks for submitting this. |
eddelbuettel
added a commit
that referenced
this pull request
Mar 22, 2016
Updating vignette for installGithub.r
eddelbuettel
merged commit d908b23
into
eddelbuettel:master
1 check passed
1 check passed
eddelbuettel
added a commit
that referenced
this pull request
Mar 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Looks like the arguments and helper script were inappropriately copy pasted from the previous description of install.r in the file. I've updated the vignette with the example at https://github.com/eddelbuettel/littler/blob/733a96ca46c1234f67ee33274f82c645ffcb5035/inst/examples/installGithub.r also included example at head of section for users not interested in details.