Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdding installIfNew.r example #59
Conversation
| } | ||
| } | ||
|
|
||
| pkgs <- setdiff(pkgs, installed.packages()[,1]) |
1beb
May 7, 2018
•
Author
Contributor
Non trivial changes are here to L70-L77
Non trivial changes are here to L70-L77
|
Let me take a closer peek at it in the next few days. First comment, confirmed from running after glancing at the code: edd@rob:~/git/littler/inst/examples(pr59/install_if_new)$ ./installIfNew.R RcppGSL
Warning message:
In install_packages2(pkgs = f, lib = lib, repos = if (isMatchingFile(f)) NULL else rep, :
All specified packages are already installed.
edd@rob:~/git/littler/inst/examples(pr59/install_if_new)$ We may want to simplify and remove pieces from |
|
It is a pretty small change to |
|
@1beb Any follow-up comment? As small as it is, should it be over in |
|
Sorry Dirk, I'm in transit will review this next week. I will program it as
you prefer it. It's really not that hard. So specify what your preference
is and I'll push an update.
…On Wed, May 9, 2018, 12:44 Dirk Eddelbuettel ***@***.***> wrote:
@1beb <https://github.com/1beb> Any follow-up comment? As small as it is,
should it be over in install2.r ? Default behaviour as is, if a (new)
flag (say, --skip-installed or something) is set it does what you added.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#59 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAZv45SRNGlcB4F6_OTxMlf1m5Ze-FrXks5twzkFgaJpZM4T0UM_>
.
|
|
In order to get on with life I am going to merge this, and then delete the new file, carrying the diff over to |
ec058c7
into
eddelbuettel:master
|
Thx. I'm in Mexico at a Bachelor party. There is no programming this week.
…On Sat, May 12, 2018, 08:15 Dirk Eddelbuettel ***@***.***> wrote:
Merged #59 <#59>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#59 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAZv4ygDnT0x9JaxgLUmqD9ZkKqpRCUYks5txu5ngaJpZM4T0UM_>
.
|
Take a look, let me know what you think. I created a new file. It is essentially a copy of
install2.rwith some support for looking atinstalled.packages(). I added a warning when no packages will be installed but I'm not actually sure how that will be handled on passthrough.