New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ncpus argument to install2.r #63

Merged
merged 2 commits into from Dec 31, 2018

Conversation

Projects
None yet
2 participants
@csgillespie
Copy link
Contributor

csgillespie commented Dec 30, 2018

  • Added ncpus argument to install2.r: -n and -ncpus
  • Default: getOption("Ncpus", 1L)
  • -n -1: max(1L, parallel::detectCores())
  • Parallel package has been around since R 2.14
  • Changed some rogue assignment operators from = to <-
  • Updated changelog

Closes #62

@eddelbuettel

This comment has been minimized.

Copy link
Owner

eddelbuettel commented Dec 30, 2018

I made some comments over in #62 where we had the prior conversation.

@eddelbuettel eddelbuettel merged commit be3b4a0 into eddelbuettel:master Dec 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eddelbuettel

This comment has been minimized.

Copy link
Owner

eddelbuettel commented Jan 6, 2019

Just wanted to once again say thanks! for that PR. I carried the idea over to update.r (which I run daily or near-daily on one or two machines) and the parallel run I now get after adding options(Ncpus=4) is rather nice. Well played, my friend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment