Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S4 changes for correct operations on 'nanotime' operands #17

Merged
merged 13 commits into from Mar 29, 2017

Conversation

@lsilvest
Copy link
Collaborator

@lsilvest lsilvest commented Mar 26, 2017

No description provided.

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Mar 26, 2017

Please make this change:

1 file changed, 1 insertion(+), 1 deletion(-)
.travis.yml | 2 +-

modified   .travis.yml
@@ -13,7 +13,7 @@ before_install:
   - ./run.sh bootstrap
 
 install:
-  - ./run.sh install_aptget r-cran-rcppcctz r-cran-bit64 r-cran-zoo r-cran-data.table
+  - ./run.sh install_aptget r-cran-rcppcctz r-cran-bit64 r-cran-zoo r-cran-data.table r-cran-runit
 
 script:
   - ./run.sh run_tests
@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Mar 26, 2017

Forgot that GH is so fancy now and lets me commit directly into your master to alter the pending PR.

So I pushed the change, and Travis should now be happier.

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Mar 26, 2017

Well turns out it is not -- while it now runs tests thanks to RUnit being installed, it still fails. So that is now a PR with busted tests so ball back in your court.

@lsilvest
Copy link
Collaborator Author

@lsilvest lsilvest commented Mar 26, 2017

Yes, it failed a test that works fine on my machine. I've created a Travis account and will look into this failure.

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Mar 26, 2017

It also passes for me on my box (as I mentioned on Slack, not sure if you're logged in).

Older compiler? Older OS version?

@eddelbuettel eddelbuettel merged commit cf0279a into eddelbuettel:master Mar 29, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.