Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 'format','tz' parameters to 'nanotime','format' and 'print' #22

Merged
merged 2 commits into from May 4, 2017

Conversation

@lsilvest
Copy link
Collaborator

@lsilvest lsilvest commented May 4, 2017

No description provided.

Copy link
Owner

@eddelbuettel eddelbuettel left a comment

Something is not right here. I'll try to hit you on Slack... Nobody home.

Sent a quick commit your way which is now part of the PR. Rest looks good.

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented May 4, 2017

Ie

R> .getTz <- function(x, tz) {
+     if (tz=="") {
+         if (!is.null(tzone <- attr(x, "tzone")))
+             tz <- tzone
+         else
+             tz <- getOption("nanotimeTz", default="UTC")
+     }
+     tz
+ }
R> .getTz(Sys.time())  # calling with missing, no default given
Error in .getTz(Sys.time()) (from nano.R!9170Nws#2) : argument "tz" is missing, with no default
R> 
@eddelbuettel eddelbuettel merged commit 6caf20d into eddelbuettel:master May 4, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.