Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 'format','tz' parameters to 'nanotime','format' and 'print' #22

Merged
merged 2 commits into from
May 4, 2017
Merged

Conversation

lsilvest
Copy link
Collaborator

@lsilvest lsilvest commented May 4, 2017

No description provided.

Copy link
Owner

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is not right here. I'll try to hit you on Slack... Nobody home.

Sent a quick commit your way which is now part of the PR. Rest looks good.

@eddelbuettel
Copy link
Owner

Ie

R> .getTz <- function(x, tz) {
+     if (tz=="") {
+         if (!is.null(tzone <- attr(x, "tzone")))
+             tz <- tzone
+         else
+             tz <- getOption("nanotimeTz", default="UTC")
+     }
+     tz
+ }
R> .getTz(Sys.time())  # calling with missing, no default given
Error in .getTz(Sys.time()) (from nano.R!9170Nws#2) : argument "tz" is missing, with no default
R> 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants