Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in order to support the changes to bit64 #33

Merged
merged 2 commits into from
Apr 19, 2018
Merged

Fixes in order to support the changes to bit64 #33

merged 2 commits into from
Apr 19, 2018

Conversation

lsilvest
Copy link
Collaborator

Fumbled a bit on this one as R 3.4.4 has some S4 method dispatch changes since 3.3.1, but should be good now.

There is a new note during the R CMD check run on Travis saying:

* checking top-level files ... NOTE
File
  LICENSE
is not mentioned in the DESCRIPTION file.

You probably know how to take care of that, and I'm supposing you will be editing DESCRIPTION anyway to alter the package version...

@codecov-io
Copy link

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #33   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          88     90    +2     
=====================================
+ Hits           88     90    +2
Impacted Files Coverage Δ
R/nanotime.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6376dd...e8fba50. Read the comment docs.

@eddelbuettel
Copy link
Owner

Awesome, thanks.

Re LICENSE: I think at some GitHub encouraged everybody to add them to the repos to be more plain. The easiest is probably a simple entry in .Rbuildignore. I have some quality time on a train tomorrow and may just take care of it then.

And I presume this squares us with the planned changed for int64 ?

@lsilvest
Copy link
Collaborator Author

Yes, I ran it against a bit64 version which has the proposed changes and it solves the issue. Thanks!

@eddelbuettel
Copy link
Owner

BTW LICENSE was already in .Rbuildignore so you must have done R CMD check to the source directory, it is preferable to run R CMD build first and to check the tarball.

All looking good so far, will have a second (real) look a bit later.

@eddelbuettel eddelbuettel merged commit 493caf2 into eddelbuettel:master Apr 19, 2018
eddelbuettel added a commit that referenced this pull request Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants