add [[ accessor (closes #44) #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 92 93 +1
=====================================
+ Hits 92 93 +1
Continue to review full report at Codecov.
|
|
It looks good to me. I verified it correctly drops names and also that it errors out with the correct error message when more than one element is selected. |
|
Beauty of S4 :) I'll merge and wrap this up. Should be on CRAN within minutes (once I wrap up the usual tests here, on winbuilder and rhub) as we have a clean sheet here. |
|
amazing job guys! I will run more tests on my side to check everything is OK. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lsilvest when you have a moment to glance at it -- this just fills in a gap we never needed filled but #44 tells us that dplyr was unhappy about this