Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add [[ accessor (closes #44) #45

Merged
merged 1 commit into from May 25, 2019

Conversation

Projects
None yet
3 participants
@eddelbuettel
Copy link
Owner

commented May 23, 2019

@lsilvest when you have a moment to glance at it -- this just fills in a gap we never needed filled but #44 tells us that dplyr was unhappy about this

@codecov

This comment has been minimized.

Copy link

commented May 23, 2019

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #45   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          92     93    +1     
=====================================
+ Hits           92     93    +1
Impacted Files Coverage Δ
R/nanotime.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2eae22...aaa33e4. Read the comment docs.

@lsilvest

This comment has been minimized.

Copy link
Contributor

commented May 25, 2019

It looks good to me. I verified it correctly drops names and also that it errors out with the correct error message when more than one element is selected.

@eddelbuettel

This comment has been minimized.

Copy link
Owner Author

commented May 25, 2019

Beauty of S4 :)

I'll merge and wrap this up. Should be on CRAN within minutes (once I wrap up the usual tests here, on winbuilder and rhub) as we have a clean sheet here.

@eddelbuettel eddelbuettel merged commit 25234ad into master May 25, 2019

4 checks passed

codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to b2eae22
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@eddelbuettel eddelbuettel deleted the feature/double_bracket branch May 25, 2019

@randomgambit

This comment has been minimized.

Copy link

commented May 25, 2019

amazing job guys! I will run more tests on my side to check everything is OK. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.