Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadd [[ accessor (closes #44) #45
Conversation
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 92 93 +1
=====================================
+ Hits 92 93 +1
Continue to review full report at Codecov.
|
|
It looks good to me. I verified it correctly drops names and also that it errors out with the correct error message when more than one element is selected. |
|
Beauty of S4 :) I'll merge and wrap this up. Should be on CRAN within minutes (once I wrap up the usual tests here, on winbuilder and rhub) as we have a clean sheet here. |
|
amazing job guys! I will run more tests on my side to check everything is OK. Thanks |
@lsilvest when you have a moment to glance at it -- this just fills in a gap we never needed filled but #44 tells us that dplyr was unhappy about this