Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide correct 'all.equal' for all types; closes #46 #63

Merged
merged 3 commits into from
Mar 31, 2020

Conversation

lsilvest
Copy link
Collaborator

Rather long because the 'all.equal' needed to be defined on all 4 types.

@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #63 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #63   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     13           
  Lines        1841   1900   +59     
=====================================
+ Hits         1841   1900   +59
Impacted Files Coverage Δ
R/nanoduration.R 100% <100%> (ø) ⬆️
R/nanotime.R 100% <100%> (ø) ⬆️
R/nanoperiod.R 100% <100%> (ø) ⬆️
R/nanoival.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4083c03...7e284c8. Read the comment docs.

Copy link
Owner

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we need all the isTRUE() around what looks like scalar values?

Edit: Right on. There are special cases (like these) where one needs it.

@eddelbuettel eddelbuettel merged commit b0ddde4 into master Mar 31, 2020
@eddelbuettel eddelbuettel deleted the fix/all.equal branch April 30, 2020 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants