Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upprovide correct 'all.equal' for all types; closes #46 #63
Conversation
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 13 13
Lines 1841 1900 +59
=====================================
+ Hits 1841 1900 +59
Continue to review full report at Codecov.
|
|
Looks good. Do we need all the Edit: Right on. There are special cases (like these) where one needs it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Rather long because the 'all.equal' needed to be defined on all 4 types.