Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement floor and ceiling; closes #64 #65

Merged
merged 1 commit into from Apr 27, 2020
Merged

Conversation

@lsilvest
Copy link
Collaborator

@lsilvest lsilvest commented Apr 26, 2020

For durations we match the xts::align.time function, and for periods we pay a bit the need to check for time zone changes, but it's a very acceptable price. Furthermore, one would use periods only for granularities of one hour or more, so in practice it should never be an issue.

                 test replications elapsed relative
3 nanotime (duration)           10   5.082    1.000
2   nanotime (period)           10  11.586    2.280
1                 xts           10   5.391    1.061
Copy link
Owner

@eddelbuettel eddelbuettel left a comment

Looks fabulous. Thanks for all the documentation and tests!

@eddelbuettel eddelbuettel merged commit fe1d20d into master Apr 27, 2020
4 checks passed
4 checks passed
codecov/patch 100.00% of diff hit (target 100.00%)
Details
codecov/project 100.00% (+0.00%) compared to 2b551ef
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@eddelbuettel eddelbuettel deleted the feature/rounding branch Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.