Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes/cleanup #67

Merged
merged 2 commits into from May 17, 2020
Merged

Fixes/cleanup #67

merged 2 commits into from May 17, 2020

Conversation

@lsilvest
Copy link
Collaborator

@lsilvest lsilvest commented May 17, 2020

Fixed all the issues in subsetting that I could find. Also implemented 'rep' for all types. I'm sure we'll have a bunch of functions that people will want to use, similar to 'rep', but I think we can implement these on an as-need-be basis, when issues come in.

lsilvest added 2 commits May 10, 2020
…orted'; document 'tz' param behaviour in constructor
Copy link
Owner

@eddelbuettel eddelbuettel left a comment

Just wow once again. Awesome work.

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented May 17, 2020

Agreed on the as-needed basis. I guess time to cut a release? Maybe as 0.3.0?

@eddelbuettel eddelbuettel merged commit 98ca197 into master May 17, 2020
4 checks passed
4 checks passed
codecov/patch 100.00% of diff hit (target 100.00%)
Details
codecov/project 100.00% (+0.00%) compared to fe1d20d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@eddelbuettel eddelbuettel deleted the fixes/cleanup branch May 17, 2020
@lsilvest
Copy link
Collaborator Author

@lsilvest lsilvest commented May 17, 2020

Yes, with all these changes I think the bump to 0.3.0 is justified! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.