Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #68; move headers to 'nanotime' dir; put 'period' and 'interva… #70

Merged
merged 2 commits into from Jul 13, 2020

Conversation

@lsilvest
Copy link
Collaborator

@lsilvest lsilvest commented Jul 11, 2020

…l' in namespace; make 'pseudovector' more flexible

…l' in namespace; make 'pseudovector' more flexible
@lsilvest lsilvest requested a review from eddelbuettel Jul 11, 2020
ChangeLog Outdated Show resolved Hide resolved
src/Makevars Outdated Show resolved Hide resolved
Copy link
Owner

@eddelbuettel eddelbuettel left a comment

Thumbs up -- just a few very minor comments.

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Jul 12, 2020

Do you want me to merge, or do we follow the usual "A proposes PR, B reviews and (maybe ;-) approves, if so A merges" pattern?

@lsilvest
Copy link
Collaborator Author

@lsilvest lsilvest commented Jul 13, 2020

Sure, I can merge.

@lsilvest lsilvest merged commit 1d90d14 into master Jul 13, 2020
4 checks passed
4 checks passed
codecov/patch 100.00% of diff hit (target 100.00%)
Details
codecov/project 100.00% (+0.00%) compared to 98ca197
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@eddelbuettel eddelbuettel deleted the fixes/includes branch Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.