Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vignette metadata to skeleton and indicated one column option #32

Merged
merged 3 commits into from Sep 19, 2017

Conversation

@coatless
Copy link
Collaborator

@coatless coatless commented Sep 18, 2017

No description provided.

@coatless coatless requested a review from eddelbuettel Sep 18, 2017
README.md Outdated
@@ -6,7 +6,7 @@ Pinp is not PNAS

The template provided by the PNAS Article template in the
[rticles](https://cran.r-project.org/package=rticles) package makes it very easy and convenient to
create attractive looking two-column papers.
create attractive looking one or two-column papers.

This comment has been minimized.

@eddelbuettel

eddelbuettel Sep 18, 2017
Owner

The one thing that rubs me the wrong way here is that it lists one-columns as if we really cared about one column.

I don't think we do, really. Pinp is about two-col defaults, with one-col thrown in because why not.

That doesn't come out here.

@coatless coatless changed the title Add vignette metadata to skeleton and indicated one column option. Add vignette metadata to skeleton, indicated one column option, and protected acknowledgements Sep 19, 2017
@coatless coatless force-pushed the enhancements/skeleton branch from 60a4291 to e9f1271 Sep 19, 2017
@coatless coatless force-pushed the enhancements/skeleton branch from e9f1271 to 7e3dc13 Sep 19, 2017
@coatless coatless changed the title Add vignette metadata to skeleton, indicated one column option, and protected acknowledgements Add vignette metadata to skeleton and indicated one column option Sep 19, 2017
@eddelbuettel eddelbuettel merged commit 99e07e3 into master Sep 19, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@eddelbuettel eddelbuettel deleted the enhancements/skeleton branch Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.