Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support 'headercolor' and 'linkcolor' from frontmatter #39

Merged
merged 5 commits into from Oct 24, 2017

Conversation

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Oct 23, 2017

No description provided.

@coatless
Copy link
Collaborator

@coatless coatless commented Oct 23, 2017

Anyway we could pass the values into the pinp.cls file like the footer defines?

@eddelbuettel
Copy link
Owner Author

@eddelbuettel eddelbuettel commented Oct 24, 2017

We could. But is it really worth it? By now pinp.cls is "ours" anyway and not fully self-contained.

@eddelbuettel
Copy link
Owner Author

@eddelbuettel eddelbuettel commented Oct 24, 2017

Well maybe we should :) I just tried two more "cleanups" just by renaming and dug myself a little hole. So reverted.

@eddelbuettel
Copy link
Owner Author

@eddelbuettel eddelbuettel commented Oct 24, 2017

Suggest to just squash merge this and move on. We had this (trivial) issue open for a while.

There is one issue that would in fact merit a release: the improved end matter. I rendered a few package vignettes since 0.0.2, and things are better now. Maybe that should go out into the world?

@coatless coatless merged commit df39ac5 into master Oct 24, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@coatless
Copy link
Collaborator

@coatless coatless commented Oct 24, 2017

I'll revisit later this week to hopefully change where the declarations are.

cc #33

@eddelbuettel
Copy link
Owner Author

@eddelbuettel eddelbuettel commented Oct 24, 2017

I keep thinking that a test suite would be good. But comparing rendered pdf files (as a formal test) is not trivial / will be fragile. People tried that with charts too.

@coatless
Copy link
Collaborator

@coatless coatless commented Oct 24, 2017

@coatless
Copy link
Collaborator

@coatless coatless commented Oct 24, 2017

Let's talk about this in #40

@eddelbuettel
Copy link
Owner Author

@eddelbuettel eddelbuettel commented Oct 24, 2017

Yes, completion to a file is good enough. We can do that in tests/someSimpleScript.R as well -- no need for extra dependencies.

@eddelbuettel eddelbuettel deleted the feature/color_choice branch Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.