New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option skip_final_break to disable \pnasbreak #47

Merged
merged 2 commits into from Nov 3, 2017

Conversation

Projects
None yet
2 participants
@coatless
Collaborator

coatless commented Nov 3, 2017

Adds an option skip_final_break. This option is disabled by default (e.g. FALSE) and, thus, \pnasbreak will now be included.

/ cc #44

@eddelbuettel

Looks good. Do we have a policy for snake_case over camelCase? Shall we clean this up and create one?

snake_case sucks but oh well.

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Nov 3, 2017

Owner

Oh, and did you have time to actually test this on the known-as-potentially-problematic vignettes?

Owner

eddelbuettel commented Nov 3, 2017

Oh, and did you have time to actually test this on the known-as-potentially-problematic vignettes?

@coatless

This comment has been minimized.

Show comment
Hide comment
@coatless

coatless Nov 3, 2017

Collaborator

Yes, I ran it against all vignettes. In particular, the #44 Rcpp-package vignette gives:

screen shot 2017-11-03 at 10 18 16 am

re snake vs camelCase: I used the format that was already common:

one_column, one_side, lead_author_surnames, et cetera...

Collaborator

coatless commented Nov 3, 2017

Yes, I ran it against all vignettes. In particular, the #44 Rcpp-package vignette gives:

screen shot 2017-11-03 at 10 18 16 am

re snake vs camelCase: I used the format that was already common:

one_column, one_side, lead_author_surnames, et cetera...

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Nov 3, 2017

Owner

Yeah, snake it is I guess. Comes from rticles too...

Owner

eddelbuettel commented Nov 3, 2017

Yeah, snake it is I guess. Comes from rticles too...

@eddelbuettel eddelbuettel merged commit 9fdab6d into master Nov 3, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Nov 4, 2017

Owner

Added one more commit with some minor edits, Rd addition and whatnot. Probably good enough to be called 0.0.4 and be shipped. Let me know if you find some warts...

Owner

eddelbuettel commented Nov 4, 2017

Added one more commit with some minor edits, Rd addition and whatnot. Probably good enough to be called 0.0.4 and be shipped. Let me know if you find some warts...

@eddelbuettel eddelbuettel deleted the bugfix/skip-final-break branch Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment