Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option skip_final_break to disable \pnasbreak #47

Merged
merged 2 commits into from
Nov 3, 2017

Conversation

coatless
Copy link
Collaborator

@coatless coatless commented Nov 3, 2017

Adds an option skip_final_break. This option is disabled by default (e.g. FALSE) and, thus, \pnasbreak will now be included.

/ cc #44

Copy link
Owner

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we have a policy for snake_case over camelCase? Shall we clean this up and create one?

snake_case sucks but oh well.

@eddelbuettel
Copy link
Owner

Oh, and did you have time to actually test this on the known-as-potentially-problematic vignettes?

@coatless
Copy link
Collaborator Author

coatless commented Nov 3, 2017

Yes, I ran it against all vignettes. In particular, the #44 Rcpp-package vignette gives:

screen shot 2017-11-03 at 10 18 16 am

re snake vs camelCase: I used the format that was already common:

one_column, one_side, lead_author_surnames, et cetera...

@eddelbuettel
Copy link
Owner

Yeah, snake it is I guess. Comes from rticles too...

@eddelbuettel eddelbuettel merged commit 9fdab6d into master Nov 3, 2017
@eddelbuettel
Copy link
Owner

Added one more commit with some minor edits, Rd addition and whatnot. Probably good enough to be called 0.0.4 and be shipped. Let me know if you find some warts...

@eddelbuettel eddelbuettel deleted the bugfix/skip-final-break branch November 6, 2017 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants