New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date_subtitle -- a YAML option to have a custom string of text in subtitle #64

Merged
merged 3 commits into from Jan 8, 2019

Conversation

Projects
None yet
3 participants
@ikashnitsky
Copy link
Contributor

ikashnitsky commented Jan 8, 2019

instead of the default "This version was compiled on \today"

ikashnitsky added some commits Jan 8, 2019

date_subtitle -- a YAML option to have a custom string of text instea…
…d of the default "This version was compiled on \today"
@ikashnitsky

This comment has been minimized.

Copy link
Contributor

ikashnitsky commented Jan 8, 2019

sorry, made a stupid mistake with dollar signs changing the name of the option

@coatless

This comment has been minimized.

Copy link
Collaborator

coatless commented Jan 8, 2019

@ikashnitsky could you also add the YAML key information after the Options section in the vignette?

https://github.com/eddelbuettel/pinp/blob/master/vignettes/pinp.Rmd#L157

@ikashnitsky

This comment has been minimized.

Copy link
Contributor

ikashnitsky commented Jan 8, 2019

@coatless ah, sorry. I've added a bullet point in ## Document Options in the skeleton.Rmd. Done now

@eddelbuettel

This comment has been minimized.

Copy link
Owner

eddelbuettel commented Jan 8, 2019

Was about to make the same comment. Only thing missing then is the ChangeLog but I can do that after the fact.

@eddelbuettel
Copy link
Owner

eddelbuettel left a comment

LGTM

@coatless coatless merged commit d7bf624 into eddelbuettel:master Jan 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@coatless

This comment has been minimized.

Copy link
Collaborator

coatless commented Jan 8, 2019

In we go! Thanks @ikashnitsky

@ikashnitsky

This comment has been minimized.

Copy link
Contributor

ikashnitsky commented Jan 8, 2019

Thank you! The package is amazing

eddelbuettel added a commit that referenced this pull request Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment