Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFeature/updated pnas (closes #77 #78) #79
Conversation
| @@ -206,14 +222,18 @@ | |||
| \RequirePackage[noend]{algpseudocode} | |||
| \RequirePackage{changepage} | |||
| \RequirePackage[twoside,% | |||
| includeheadfoot, | |||
| letterpaper,includeheadfoot,% | |||
| layoutsize={8.125in,10.875in},% | |||
coatless
Sep 8, 2019
Collaborator
From what I recall, this was dropped in the pinp class before.
From what I recall, this was dropped in the pinp class before.
eddelbuettel
Sep 8, 2019
Author
Owner
As in not enforcing us paper? Possibly.
(Check master)
Yup. So just nix the line? Or is there more? Can you find the commit(s) where we did that? (Just in from a run myself...)
As in not enforcing us paper? Possibly.
(Check master)
Yup. So just nix the line? Or is there more? Can you find the commit(s) where we did that? (Just in from a run myself...)
| \@ifundefined{@acknow}{}{\acknow@section{Acknowledgments}\@acknow} | ||
| \@ifundefined{@acknow}{}{ | ||
| \vskip 3.25ex plus 1ex minus .2ex | ||
| \noindent{\sffamily\normalsize\bfseries ACKNOWLEDGMENTS.\hspace{1.5ex plus .2ex}} |
coatless
Sep 8, 2019
Collaborator
Suggested change
\noindent{\sffamily\normalsize\bfseries ACKNOWLEDGMENTS.\hspace{1.5ex plus .2ex}}
\noindent{\sffamily\normalsize\bfseries Acknowledgements.\hspace{1.5ex plus .2ex}}
| \noindent{\sffamily\normalsize\bfseries ACKNOWLEDGMENTS.\hspace{1.5ex plus .2ex}} | |
| \noindent{\sffamily\normalsize\bfseries Acknowledgements.\hspace{1.5ex plus .2ex}} |
eddelbuettel
Sep 8, 2019
Author
Owner
That's good. I won't commit from the PR. Let's just collect all "post processing" in one commit.
That's good. I won't commit from the PR. Let's just collect all "post processing" in one commit.
| \renewcommand\Authands{, and } | ||
|
|
||
| %% Choose template type | ||
| \newcommand*{\templatetype}[1]{% |
coatless
Sep 8, 2019
Collaborator
I think we also dropped this.
I think we also dropped this.
eddelbuettel
Sep 8, 2019
Author
Owner
Ok
Ok
eddelbuettel
Sep 8, 2019
Author
Owner
Good catch. I even tried being cute and leaving it in for "advanced" users but on pnasinvited (after copying the .sty in) in balks on a redefinition, and on pnasmatematics ... nothing happens (for the one-col test file I used).
Good catch. I even tried being cute and leaving it in for "advanced" users but on pnasinvited (after copying the .sty in) in balks on a redefinition, and on pnasmatematics ... nothing happens (for the one-col test file I used).
|
LGTM overall. Only one nit on the aesthetic change w.r.t |
|
Do you want to follow up with one commit (in the branch / pr) to finalize? |
|
Thanks for making the changes. Just got back to the office after dropping my bike off for repair. |
|
Ick. Broken bike sucks. Last time mine needed care it was gone for a week :-/ |
|
Downside of |
This looks ready. I tested it with most of the Rcpp vignette. The gnarly typesetting at the end is different now -- reference just become normal content of a column and 'flow'. I like that.
Some things appear to have changed, and have annoyed me for a while via persistent bickering from LaTeX itself over lack of options are a
letter(or papersize) and now alsoprintwatermark. So I removed mentions of them from thetemplate.tex,skeleton.Rmdand the pair ofRandRmd. If you want watermarks back we have to start from the top and support it as an option to document type. It's just not that important to me. (One can still, it seems, toggle by flipping the value in the line\setboolean{displaywatermark}{false} % Set to true to show the watermark -- pinp changeback to true. Good enough for me.
Let me know what you think.