Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/updated pnas (closes #77 #78) #79

Merged
merged 6 commits into from Sep 8, 2019

Conversation

@eddelbuettel
Copy link
Owner

commented Sep 8, 2019

This looks ready. I tested it with most of the Rcpp vignette. The gnarly typesetting at the end is different now -- reference just become normal content of a column and 'flow'. I like that.

Some things appear to have changed, and have annoyed me for a while via persistent bickering from LaTeX itself over lack of options are a letter (or papersize) and now also printwatermark. So I removed mentions of them from the template.tex, skeleton.Rmd and the pair of R and Rmd. If you want watermarks back we have to start from the top and support it as an option to document type. It's just not that important to me. (One can still, it seems, toggle by flipping the value in the line
\setboolean{displaywatermark}{false} % Set to true to show the watermark -- pinp change
back to true. Good enough for me.

Let me know what you think.

@@ -206,14 +222,18 @@
\RequirePackage[noend]{algpseudocode}
\RequirePackage{changepage}
\RequirePackage[twoside,%
includeheadfoot,
letterpaper,includeheadfoot,%
layoutsize={8.125in,10.875in},%

This comment has been minimized.

Copy link
@coatless

coatless Sep 8, 2019

Collaborator

From what I recall, this was dropped in the pinp class before.

This comment has been minimized.

Copy link
@eddelbuettel

eddelbuettel Sep 8, 2019

Author Owner

As in not enforcing us paper? Possibly.

(Check master)

Yup. So just nix the line? Or is there more? Can you find the commit(s) where we did that? (Just in from a run myself...)

\@ifundefined{@acknow}{}{\acknow@section{Acknowledgments}\@acknow}
\@ifundefined{@acknow}{}{
\vskip 3.25ex plus 1ex minus .2ex
\noindent{\sffamily\normalsize\bfseries ACKNOWLEDGMENTS.\hspace{1.5ex plus .2ex}}

This comment has been minimized.

Copy link
@coatless

coatless Sep 8, 2019

Collaborator
Suggested change
\noindent{\sffamily\normalsize\bfseries ACKNOWLEDGMENTS.\hspace{1.5ex plus .2ex}}
\noindent{\sffamily\normalsize\bfseries Acknowledgements.\hspace{1.5ex plus .2ex}}

This comment has been minimized.

Copy link
@eddelbuettel

eddelbuettel Sep 8, 2019

Author Owner

That's good. I won't commit from the PR. Let's just collect all "post processing" in one commit.

\renewcommand\Authands{, and }

%% Choose template type
\newcommand*{\templatetype}[1]{%

This comment has been minimized.

Copy link
@coatless

coatless Sep 8, 2019

Collaborator

I think we also dropped this.

This comment has been minimized.

Copy link
@eddelbuettel

eddelbuettel Sep 8, 2019

Author Owner

Ok

This comment has been minimized.

Copy link
@eddelbuettel

eddelbuettel Sep 8, 2019

Author Owner

Good catch. I even tried being cute and leaving it in for "advanced" users but on pnasinvited (after copying the .sty in) in balks on a redefinition, and on pnasmatematics ... nothing happens (for the one-col test file I used).

@coatless

This comment has been minimized.

Copy link
Collaborator

commented Sep 8, 2019

LGTM overall. Only one nit on the aesthetic change w.r.t Acknowledgements.

@eddelbuettel

This comment has been minimized.

Copy link
Owner Author

commented Sep 8, 2019

Do you want to follow up with one commit (in the branch / pr) to finalize?

@coatless

This comment has been minimized.

Copy link
Collaborator

commented Sep 8, 2019

Thanks for making the changes. Just got back to the office after dropping my bike off for repair.

@eddelbuettel

This comment has been minimized.

Copy link
Owner Author

commented Sep 8, 2019

Ick. Broken bike sucks. Last time mine needed care it was gone for a week :-/

@eddelbuettel eddelbuettel merged commit c20a0b1 into master Sep 8, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@coatless

This comment has been minimized.

Copy link
Collaborator

commented Sep 8, 2019

Downside of pinp is autocorrection to ping.

@eddelbuettel eddelbuettel deleted the feature/updated_pnas branch Sep 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.