Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add columns mode used by pandoc's :::::: and ::: blocks (closes #87) #88

Merged
merged 1 commit into from Sep 28, 2020

Conversation

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Sep 27, 2020

See #87 for discussion. Works as tested on the vignette that previously needed it in the header.

@coatless
Copy link
Collaborator

@coatless coatless commented Sep 27, 2020

Maybe add a documentation note the README vignette and pinp layout call mentioning this is supported?

pinp/vignettes/pinp.Rmd

Lines 55 to 62 in 4fc965b

# Optional: Force one-column layout, default is two-column
#one_column: true
# Optional: Enables lineo mode, but only if one_column mode is also true
#lineno: true
# Optional: Enable one-sided layout, default is two-sided
#one_sided: true

pinp/R/pinp.R

Lines 68 to 71 in 4fc965b

#' \item{\code{one_column}}{(Optional) Logical value to select
#' one-column mode, default is false.}
#' \item{\code{one_sided}}{(Optional) Logical value to select
#' one-sided format, default is false.}

@eddelbuettel
Copy link
Owner Author

@eddelbuettel eddelbuettel commented Sep 27, 2020

Could do but not urgent and can be done later. It's optional anyway at the pandoc level. Just that before the additional it broke 😿 and now it no longer does.

It also very much does not need a YAML option. Hence "maybe not".

@eddelbuettel
Copy link
Owner Author

@eddelbuettel eddelbuettel commented Sep 28, 2020

The other issue for 'maybe not' is that the side-by-side view of code .... pretty much needs one-column mode which does not fit into our default vignette (as easily). We could try to prove a point and have two columns side-by-side inside one column but it likely going to be awkward.

Your reminder about documenting options is good though.

@eddelbuettel eddelbuettel merged commit 0f8b22f into master Sep 28, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@eddelbuettel
Copy link
Owner Author

@eddelbuettel eddelbuettel commented Sep 28, 2020

For completeness, I tried it. Outer \begin{widetext} ... \end{widetext} then clashes with the width setting pandoc supports. Switching with \onecolumn and back to \twocolumn works, but forces a pagebreak. So not really a candidate for our default vignette.

@eddelbuettel eddelbuettel deleted the feature/multi_column branch Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.