Skip to content

/ pkgkitten

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slightly broken R-exts.html URL #7

Merged
merged 1 commit into from Jan 30, 2016
Merged

Fix slightly broken R-exts.html URL #7

merged 1 commit into from Jan 30, 2016
+1 −1

Conversation

@JoshOBrien
Copy link
Contributor

@JoshOBrien JoshOBrien commented Jan 30, 2016

No description provided.

@JoshOBrien
Fix slightly broken R-exts.html URL
Loading status checks…
19a1825
@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Jan 30, 2016

Ooops. Thanks for catching that!

Any other suggestions or enhancement proposals now that you gave it a spin?
eddelbuettel added a commit that referenced this pull request Jan 30, 2016
@eddelbuettel
Merge pull request #7 from JoshOBrien/master
Loading status checks…
cb74e80 
Fix slightly broken R-exts.html URL
@eddelbuettel eddelbuettel merged commit cb74e80 into eddelbuettel:master Jan 30, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@JoshOBrien
Copy link
Contributor Author

@JoshOBrien JoshOBrien commented Feb 1, 2016

Nope, I really wouldn't change a thing.

I of course don't really need or want the hello.R and hello.Rd, and you
could have a 'minimal=' formal allowing me to not produce them in the
first place. But then the source tree wouldn't pass R CMD check straight
out of the box, so I think it's best to just leave well enough alone,
keeping the package simple in concept and interface.

Nicely done -- thanks.

On Sat, Jan 30, 2016 at 3:52 PM, Dirk Eddelbuettel <notifications@github.com

wrote:

Ooops. Thanks for catching that!

Any other suggestions or enhancement proposals now that you gave it a spin?

—
Reply to this email directly or view it on GitHub
#7 (comment).
@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Feb 1, 2016

👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@JoshOBrien @eddelbuettel
You can’t perform that action at this time.