Enable building on Windows #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An attempt to install the package on Windows (after removing the OS
restriction) resulted in the following warning:
datetime.c:102:14: warning: 'tzname' redeclared without dllimport attribute: previous dllimport ignored [-Wattributes]
extern char *tzname[2];
^
The fix is to declare tzname with the dllimport attribute, as was done
for Cygwin.
While researching how R itself configures this block of code, I learned
that USE_INTERNAL_MKTIME is set by default. It is unset if configure
determines that the system tools behave reasonably. It's set by default
on MacOS, and it's what is used on Windows.
eddelbuettel
approved these changes
Mar 25, 2017
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
=======================================
Coverage 53.24% 53.24%
=======================================
Files 5 5
Lines 971 971
=======================================
Hits 517 517
Misses 454 454
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to install the package on Windows (after removing the OS
restriction) resulted in the following warning:
The fix is to declare tzname with the dllimport attribute, as was done
for Cygwin.
While researching how R itself configures this block of code, I learned
that USE_INTERNAL_MKTIME is set by default. It is unset if configure
determines that the system tools behave reasonably. It's set by default
on MacOS, and it's what is used on Windows.