Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.0.15 broke BiocNeighbors #57

Closed
lcolladotor opened this issue Feb 27, 2020 · 7 comments
Closed

Version 0.0.15 broke BiocNeighbors #57

lcolladotor opened this issue Feb 27, 2020 · 7 comments

Comments

@lcolladotor
Copy link

Hi,

I'm unfamiliar with RcppAnnoy but I just ran into an issue where the changes from 0.0.14 to 0.0.15 broke the reverse dependency BiocNeighbors as I described in detailed to @LTLA
at LTLA/BiocNeighbors#10. I'm letting you know as it could involve a fix either on the BiocNeighbors side or the RcppAnnoy one (I just don't know).

I noticed this while trying to update https://jhubiostatistics.shinyapps.io/spatialLIBD/.

Best,
Leo

@eddelbuettel
Copy link
Owner

Thanks for the heads, I am sure @LTLA and I should be able to sort it out.

@eddelbuettel
Copy link
Owner

(This is now taken care of in master thanks to very nice flurry of activity by @erikbern @jlmelville @LTLA and myself. We should have 0.0.16 on CRAN by end of week; I will close it then. If anybody needs a tarball of 0.0.15.2 in a drat-able repo let me know, else just fetch master.)

@lcolladotor
Copy link
Author

Awesome, thanks for all the work and the updates! I'll keep an eye for 0.0.16 as that's what's stopping Bioconductor/Contributions#1389 (comment) (I don't think that I can use another RcppAnnoy version in Bioconductor's Single Package Builder infrastructure besides the latest from CRAN).

Best,
Leo

@eddelbuettel
Copy link
Owner

If you need a new version NOW (ie today) I can roll one up into a drat you can call via Suggests: and Additional_Repositiries.

Otherwise by end of week / weekend / Monday at the latest a new 0.0.16 will on CRAN, and it will be awesome.

@LTLA
Copy link
Contributor

LTLA commented Mar 3, 2020

@lcolladotor I don't understand. BiocNeighbors is all green on BioC-release and Bioc-devel.

@lcolladotor
Copy link
Author

Ohh, ok! Thanks to the both of you!

I dropped all the code related to RcppAnnoy's versions at LieberInstitute/spatialLIBD@5024450 and it all works again (both on Travis and BioC's SBP). I didn't realize earlier that I didn't need to wait for 0.0.16. Thanks!!

Best,
Leo

@eddelbuettel
Copy link
Owner

This is also fixed in 0.0.16 now on CRAN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants