New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick start vignette for C++ use from R packages #29

Merged
merged 4 commits into from Oct 6, 2018

Conversation

Projects
None yet
2 participants
@LTLA
Contributor

LTLA commented Oct 6, 2018

Closes #19. I used a vignette out of force of habit, but feel free to move it somewhere more appropriate.

@eddelbuettel

This comment has been minimized.

Owner

eddelbuettel commented Oct 6, 2018

Awesome. Will peruse and read.

Because I use Travis CI via this setup (of mine) we need to add
r-cran-knitr r-cran-rmarkdown to

- ./run.sh install_aptget r-cran-runit r-cran-rcpp

Can you please add that to the PR?

@eddelbuettel

This comment has been minimized.

Owner

eddelbuettel commented Oct 6, 2018

That did it. Had to restart one of the two subtests as the Ubuntu repo had timed out.

Will merge this. Would you mind if I converted this to using pinp which a few of my packages use for vignettes? I prefer pdf (but it's not a must -- I kept some other vignettes in html).

@eddelbuettel

This comment has been minimized.

Owner

eddelbuettel commented Oct 6, 2018

Also, I had some work piled up for RcppAnnoy incl a mini PR I pushed upstream to this will get rolled up soon I suspect.

@eddelbuettel eddelbuettel merged commit 3c73f14 into eddelbuettel:master Oct 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@LTLA

This comment has been minimized.

Contributor

LTLA commented Oct 6, 2018

That's fine, I've no problems with pinp. Looking forward to the next release.

@LTLA

This comment has been minimized.

Contributor

LTLA commented Oct 6, 2018

Speaking of mini-PRs, I also pushed one upstream (spotify/annoy#313) so it'll be good if that could get into the next RcppAnnoy release as well.

@eddelbuettel

This comment has been minimized.

Owner

eddelbuettel commented Oct 6, 2018

Cool! I'll ping you before I roll this up, and if you follow this repo you'll see anyway when I commit.

I usually sync with whatever Erik has in his master at a point in time, so as you're merged you should be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment