Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upvignette polish #35
vignette polish #35
Conversation
|
Looks pretty good to me. The only thing I would suggest is to modify the BiocNeighbors citation to:
and just cite it like that. I've updated the repo but it hasn't yet propagated through BioC's build system. |
|
I am sorry, you had mentioned that before. Do I understand you correctly as in cite this instead of |
|
No problems - instead of, please. (FYI, the other two citations refer to a specific algorithm that doesn't have anything to do with Annoy and is now only a subset of what BiocNeighbors currently provides.) |
|
Cool. While I was at it, I replaced the book citation with the more current intro article on Rcpp. Now all references are 2018. Hah! |
@LTLA Please have a look:
\pkg{}and\proglang{}Ok?
PS: Oh, and renamed as mentioned earlier. Filename same as title now.