New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vignette polish #35

Merged
merged 2 commits into from Oct 16, 2018

Conversation

Projects
None yet
2 participants
@eddelbuettel
Owner

eddelbuettel commented Oct 16, 2018

@LTLA Please have a look:

  • No content changes
  • But use of \pkg{} and \proglang{}
  • Plus citation(s) of Rcpp.

Ok?

PS: Oh, and renamed as mentioned earlier. Filename same as title now.

@LTLA

This comment has been minimized.

Contributor

LTLA commented Oct 16, 2018

Looks pretty good to me. The only thing I would suggest is to modify the BiocNeighbors citation to:

  @Manual{Bioc:BiocNeighbors,
    title = {BiocNeighbors: Nearest Neighbor Detection for Bioconductor Packages},
    author = {Aaron Lun},
    year = {2018},
    note = {R package version 0.99.22},
  }

and just cite it like that. I've updated the repo but it hasn't yet propagated through BioC's build system.

@eddelbuettel

This comment has been minimized.

Owner

eddelbuettel commented Oct 16, 2018

I am sorry, you had mentioned that before.

Do I understand you correctly as in cite this instead of \citep{Wang:2012,Lun+Richard+Marioni:2017}?
Or as well as?

@LTLA

This comment has been minimized.

Contributor

LTLA commented Oct 16, 2018

No problems - instead of, please. (FYI, the other two citations refer to a specific algorithm that doesn't have anything to do with Annoy and is now only a subset of what BiocNeighbors currently provides.)

@eddelbuettel

This comment has been minimized.

Owner

eddelbuettel commented Oct 16, 2018

Cool. While I was at it, I replaced the book citation with the more current intro article on Rcpp. Now all references are 2018. Hah!

@eddelbuettel eddelbuettel merged commit 4e6f337 into master Oct 16, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment