add further documentation #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
reviewed
May 7, 2019
There was a problem hiding this comment.
That looks straightforward enough.
As a general viewpoint, I do not believe in replacing working setups just for the sake of making changes. So I would delete lines 1 to 24 of annoy.R -- the per-package Rd file is perfectly content to have been hand-written. Plastering over it also, among other things, destroys commit history for that file.
|
Seems reasonable to me. I deleted the |
|
Sorry for the delay, I am usually quicker. I am also working on some updates to testing as a first test of the new tinytest by @markvanderloo and both of those changes should go out relatively "soon". |
eddelbuettel
added a commit
that referenced
this pull request
May 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
roxygen2style documentation for package to address #43