Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added '_RcppCCTZ_convertToCivilSecond' and '_RcppCCTZ_convertToTimePo… #34

Merged
merged 1 commit into from Nov 15, 2019

Conversation

@lsilvest
Copy link
Contributor

@lsilvest lsilvest commented Nov 15, 2019

These two functions are necessary for nanotime at the C level. They are two of the main functions that are in the cctz API.

@eddelbuettel eddelbuettel merged commit 7a5154a into eddelbuettel:master Nov 15, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Nov 15, 2019

The only question I have is ... do we maybe need the same at resolutions higher than seconds too?

@lsilvest
Copy link
Contributor Author

@lsilvest lsilvest commented Nov 16, 2019

I don't think that's necessary, because higher resolutions can simply be added to the result in seconds (and the seconds result gets multiplied by the appropriate resolution of course). That's what the new nanotime does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.