Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMsgpack_read/write and some minor improvements #13
Conversation
| @@ -1,8 +1,8 @@ | |||
| Package: RcppMsgPack | |||
| Type: Package | |||
| Title: 'MsgPack' C++ Header Files and Interface Functions for R | |||
| Version: 0.2.2 | |||
| Date: 2018-05-06 | |||
| Version: 0.2.3 | |||
eddelbuettel
Jun 21, 2018
Owner
I would call this 0.2.2.1 for the PR, and only go to 0.2.3 once we're ready for CRAN but no need to change it, I can do this here.
I would call this 0.2.2.1 for the PR, and only go to 0.2.3 once we're ready for CRAN but no need to change it, I can do this here.
| @@ -3,4 +3,5 @@ importFrom("Rcpp", "evalCpp") | |||
| export("msgpack_format", "msgpack_map", "msgpack_pack", "msgpack_simplify", "msgpack_unpack", | |||
| "msgpackFormat", "msgpackMap", "msgpackPack", "msgpackSimplify", "msgpackUnpack", | |||
| "msgpack_timestamp_encode", "msgpackTimestampEncode", "msgpack_timestamp_decode", "msgpackTimestampDecode", | |||
| "msgpack_write", "msgpackWrite", "msgpack_read", "msgpackRead", | |||
eddelbuettel
Jun 21, 2018
Owner
I absolutely love our double convention :) Others should follow our lead ;-)
I absolutely love our double convention :) Others should follow our lead ;-)
| @@ -49,13 +49,13 @@ BEGIN_RCPP | |||
| END_RCPP | |||
| } | |||
| // c_timestamp_encode | |||
| RawVector c_timestamp_encode(double seconds, uint32_t nanoseconds); | |||
| RawVector c_timestamp_encode(double seconds, u_int32_t nanoseconds); | |||
eddelbuettel
Jun 21, 2018
Owner
I would have thought uint32_t was more common / standard? I guess you like how u_ sticks out?
I would have thought uint32_t was more common / standard? I guess you like how u_ sticks out?
|
Looks solid. I did not dive into the cpp file as GH did not show it, and it is a bit weird that the one test file shows it as a complete change. Oh well. Will merge once travis is through. |
eddelbuettel
merged commit 9504c6e
into
eddelbuettel:master
|
Pretty minor changes in C++. I'll summarize:
|
|
Hm, trying to think if I presume you had been running code like that your side for a while? Rest sounds cool -- nice work, once again! |
|
I haven't tested it extensively, but so far I haven't seen any problems. I'm guessing there might be an issue with scope/deallocation of the underlying data? Since I'm not returning or passing the vector around, perhaps we don't have to worry about that. |
also updated NEWS and ChangeLog for #13
No description provided.