Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upexplicit Rcpp::as<> and uint32_t for solaris compilation #15
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hi @traversc
CRAN offers these checks about how the package(s) are doing and I have been slowly working down my liist of
ERRORoutcomes. The report for our package shows a build-failure on Solaris.Because we generally did not have (easy) access to Solaris I mostly ignored these over the years. But RHub can build on Solaris, so I gave this a shot. The PR is actually pretty small. We need to disambiguate
as<>()with aRcpp::prefix, and for some reason we (again?) have the dreadedu_int32_twhen it should beuint32_tper thecsdtintheader.Please take a look if you get a minute, this is not changing any internals or behavior and should be simple.