GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No description provided.
Or maybe I am confused? Did you add to this one, or are you planning a new one?
I made the changes you mentioned in your email earlier today, so I will do another pull request in a moment.
Oh, I see the pull request updated automatically. My mistake!
No worries. Once one gets to used to this, it actually makes sense: a PR as an evolving, updateable unit composed of several commits.
Here we generally only need line 14 and not 13, but that is totally small fry. No worries, and easy to fix next time.
This may change when I re-run this. With Rcpp 0.12.12 -- on CRAN for a few weeks now -- it should no longer generate a .Call() with PACKAGE=. To be seen, also no worries.
Turns out it was the missing .registration=TRUE in NAMESPACE. No worries,
Good catch :)