New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with functions #4

Merged
merged 3 commits into from Sep 6, 2017

Conversation

Projects
None yet
2 participants
@traversc
Contributor

traversc commented Sep 4, 2017

No description provided.

@traversc traversc closed this Sep 6, 2017

@eddelbuettel eddelbuettel reopened this Sep 6, 2017

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Sep 6, 2017

Owner

Or maybe I am confused? Did you add to this one, or are you planning a new one?

Owner

eddelbuettel commented Sep 6, 2017

Or maybe I am confused? Did you add to this one, or are you planning a new one?

@traversc

This comment has been minimized.

Show comment
Hide comment
@traversc

traversc Sep 6, 2017

Contributor

I made the changes you mentioned in your email earlier today, so I will do another pull request in a moment.

Contributor

traversc commented Sep 6, 2017

I made the changes you mentioned in your email earlier today, so I will do another pull request in a moment.

@traversc

This comment has been minimized.

Show comment
Hide comment
@traversc

traversc Sep 6, 2017

Contributor

Oh, I see the pull request updated automatically. My mistake!

Contributor

traversc commented Sep 6, 2017

Oh, I see the pull request updated automatically. My mistake!

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Sep 6, 2017

Owner

No worries. Once one gets to used to this, it actually makes sense: a PR as an evolving, updateable unit composed of several commits.

Owner

eddelbuettel commented Sep 6, 2017

No worries. Once one gets to used to this, it actually makes sense: a PR as an evolving, updateable unit composed of several commits.

export(arrayEx)
export(enumEx)
import(Rcpp)
importFrom(Rcpp,evalCpp)

This comment has been minimized.

@eddelbuettel

eddelbuettel Sep 6, 2017

Owner

Here we generally only need line 14 and not 13, but that is totally small fry. No worries, and easy to fix next time.

@eddelbuettel

eddelbuettel Sep 6, 2017

Owner

Here we generally only need line 14 and not 13, but that is totally small fry. No worries, and easy to fix next time.

@@ -1,14 +1,22 @@
# Generated by using Rcpp::compileAttributes() -> do not edit by hand
# Generator token: 10BE3573-1514-4C36-9D1C-5A225CD40393
c_pack <- function(root_obj) {
.Call('_RcppMsgPack_c_pack', PACKAGE = 'RcppMsgPack', root_obj)

This comment has been minimized.

@eddelbuettel

eddelbuettel Sep 6, 2017

Owner

This may change when I re-run this. With Rcpp 0.12.12 -- on CRAN for a few weeks now -- it should no longer generate a .Call() with PACKAGE=. To be seen, also no worries.

@eddelbuettel

eddelbuettel Sep 6, 2017

Owner

This may change when I re-run this. With Rcpp 0.12.12 -- on CRAN for a few weeks now -- it should no longer generate a .Call() with PACKAGE=. To be seen, also no worries.

This comment has been minimized.

@eddelbuettel

eddelbuettel Sep 6, 2017

Owner

Turns out it was the missing .registration=TRUE in NAMESPACE. No worries,

@eddelbuettel

eddelbuettel Sep 6, 2017

Owner

Turns out it was the missing .registration=TRUE in NAMESPACE. No worries,

@@ -1,4 +1,4 @@
## RcppMsgPack [![Build Status](https://travis-ci.org/eddelbuettel/rcppmsgpack.svg)](https://travis-ci.org/eddelbuettel/rcppmsgpack) [![License](https://eddelbuettel.github.io/badges/GPL2+.svg)](http://www.gnu.org/licenses/gpl-2.0.html) [![CRAN](http://www.r-pkg.org/badges/version/RcppMsgPack)](https://cran.r-project.org/package=RcppMsgPack) [![Downloads](http://cranlogs.r-pkg.org/badges/RcppMsgPack?color=brightgreen)](http://www.r-pkg.org/pkg/MsgPack)
## RcppMsgPack [![Build Status](https://travis-ci.org/eddelbuettel/rcppmsgpack.svg)](https://travis-ci.org/eddelbuettel/rcppmsgpack) [![License](https://eddelbuettel.github.io/badges/GPL2+.svg)](http://www.gnu.org/licenses/gpl-2.0.html) [![CRAN](http://www.r-pkg.org/badges/version/RcppMsgPack)](https://cran.r-project.org/package=RcppMsgPack) [![Downloads](http://cranlogs.r-pkg.org/badges/RcppMsgPack?color=brightgreen)](http://www.r-pkg.org/pkg/RcppMsgPack)

This comment has been minimized.

@eddelbuettel

eddelbuettel Sep 6, 2017

Owner

Good catch :)

@eddelbuettel

eddelbuettel Sep 6, 2017

Owner

Good catch :)

@eddelbuettel eddelbuettel merged commit 88222f0 into eddelbuettel:master Sep 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment