Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate with functions #4
Conversation
|
Or maybe I am confused? Did you add to this one, or are you planning a new one? |
|
I made the changes you mentioned in your email earlier today, so I will do another pull request in a moment. |
|
Oh, I see the pull request updated automatically. My mistake! |
|
No worries. Once one gets to used to this, it actually makes sense: a PR as an evolving, updateable unit composed of several commits. |
|
Looks good. |
| export(arrayEx) | ||
| export(enumEx) | ||
| import(Rcpp) | ||
| importFrom(Rcpp,evalCpp) |
eddelbuettel
Sep 6, 2017
Owner
Here we generally only need line 14 and not 13, but that is totally small fry. No worries, and easy to fix next time.
Here we generally only need line 14 and not 13, but that is totally small fry. No worries, and easy to fix next time.
| @@ -1,14 +1,22 @@ | |||
| # Generated by using Rcpp::compileAttributes() -> do not edit by hand | |||
| # Generator token: 10BE3573-1514-4C36-9D1C-5A225CD40393 | |||
|
|
|||
| c_pack <- function(root_obj) { | |||
| .Call('_RcppMsgPack_c_pack', PACKAGE = 'RcppMsgPack', root_obj) | |||
eddelbuettel
Sep 6, 2017
Owner
This may change when I re-run this. With Rcpp 0.12.12 -- on CRAN for a few weeks now -- it should no longer generate a .Call() with PACKAGE=. To be seen, also no worries.
This may change when I re-run this. With Rcpp 0.12.12 -- on CRAN for a few weeks now -- it should no longer generate a .Call() with PACKAGE=. To be seen, also no worries.
eddelbuettel
Sep 6, 2017
Owner
Turns out it was the missing .registration=TRUE in NAMESPACE. No worries,
Turns out it was the missing .registration=TRUE in NAMESPACE. No worries,
| @@ -1,4 +1,4 @@ | |||
| ## RcppMsgPack [](https://travis-ci.org/eddelbuettel/rcppmsgpack) [](http://www.gnu.org/licenses/gpl-2.0.html) [](https://cran.r-project.org/package=RcppMsgPack) [](http://www.r-pkg.org/pkg/MsgPack) | |||
| ## RcppMsgPack [](https://travis-ci.org/eddelbuettel/rcppmsgpack) [](http://www.gnu.org/licenses/gpl-2.0.html) [](https://cran.r-project.org/package=RcppMsgPack) [](http://www.r-pkg.org/pkg/RcppMsgPack) | |||
eddelbuettel
Sep 6, 2017
Owner
Good catch :)
Good catch :)
eddelbuettel
merged commit 88222f0
into
eddelbuettel:master
No description provided.