New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some additions to documentation #6

Merged
merged 5 commits into from Sep 7, 2017

Conversation

Projects
None yet
2 participants
@traversc
Contributor

traversc commented Sep 7, 2017

Some additions to documentation. Feel free to change or remove anything as you see fit.

@@ -1,20 +1,22 @@
Package: RcppMsgPack
Type: Package
Title: 'MsgPack' C++ Header Files
Title: 'MsgPack' C++ Header Files and R interface functions

This comment has been minimized.

@eddelbuettel

eddelbuettel Sep 7, 2017

Owner

Yes, I noticed that too. Sorry for overlooking it pre-release.

@@ -1,6 +1,6 @@
## RcppMsgPack [![Build Status](https://travis-ci.org/eddelbuettel/rcppmsgpack.svg)](https://travis-ci.org/eddelbuettel/rcppmsgpack) [![License](https://eddelbuettel.github.io/badges/GPL2+.svg)](http://www.gnu.org/licenses/gpl-2.0.html) [![CRAN](http://www.r-pkg.org/badges/version/RcppMsgPack)](https://cran.r-project.org/package=RcppMsgPack) [![Downloads](http://cranlogs.r-pkg.org/badges/RcppMsgPack?color=brightgreen)](http://www.r-pkg.org/pkg/RcppMsgPack)
MsgPack Headers for R
MsgPack Headers for R and interface functions

This comment has been minimized.

@eddelbuettel

eddelbuettel Sep 7, 2017

Owner

Maybe capitalize? 'Interface Functions' ? Next time.

2. In R, install devtools: `install.packages("devtools")`
3. `library(devtools)`
4. `install_github("eddelbuettel/RcppMsgPack")`
1. `Install.packages("RcppMsgPack")`

This comment has been minimized.

@eddelbuettel

eddelbuettel Sep 7, 2017

Owner

lower case I here.

2. In R, install devtools: `install.packages("devtools")`
3. `library(devtools)`
4. `install_github("traversc/msgpack2R")`
1. `Install.packages("RcppMsgPack")`

This comment has been minimized.

@eddelbuettel

eddelbuettel Sep 7, 2017

Owner

Same here.

Was about to make the same changes re Windows. Should be easier once Uwe's builder kicks in.

@eddelbuettel eddelbuettel merged commit 2662c93 into eddelbuettel:master Sep 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment