New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NA values and Msgpack Timestamp type #9

Merged
merged 4 commits into from Oct 1, 2017

Conversation

Projects
None yet
2 participants
@traversc
Contributor

traversc commented Oct 1, 2017

No description provided.

@eddelbuettel

Love it, as I love time series support.

Have a look though at RcppCCTZ. I do something similar there with nanoseconds. In function parseDouble() in file src/utilities I think started with the round() approach but later whent to truncation as is done now.

We can iron that out in another round.

@eddelbuettel eddelbuettel merged commit 95019e0 into eddelbuettel:master Oct 1, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@traversc

This comment has been minimized.

Contributor

traversc commented Oct 2, 2017

Hi Dirk, from the parseDouble function, I see this:

        auto nanoseconds = tp.time_since_epoch().count();
        auto secs = nanoseconds / 1000000000;
        auto nanos = nanoseconds - secs * 1000000000;

How would we adopt that here?

@eddelbuettel

This comment has been minimized.

Owner

eddelbuettel commented Oct 2, 2017

I think so. That is what I had in mind, and there may be old cases / demos / ... in the issues of the previous approach with round() failing. I think this using integer math only and is more robust?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment