Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTests of new list methods; list methods return NULL if empty / non-existent #13
Conversation
…(length of list) for the value specified by redis. Note: The current code may have a type inconsistency in that the native return from redis is an unsigned integer. However, because .Machine$integer.max is signed I don't coerce the response into an integer and instead allow it to return as a numeric. I'm not 100% of the sure of the consequences of this decision.
…e certainly are other behaviors possible, but this seems reasonably consistent with listLPop which on a non-existent key returns redis' (nil).
…t was returning 0 rather than the expected 1. Fixed and made the comment reflect the actual test.
eddelbuettel
added a commit
that referenced
this pull request
Oct 4, 2015
Tests of new list methods; list methods return NULL if empty / non-existent
eddelbuettel
merged commit 462eedf
into
eddelbuettel:master
1 check passed
1 check passed
eddelbuettel
added a commit
that referenced
this pull request
Oct 4, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR:
My apologies for the piecemeal contribution and appreciation for @eddelbuettel 's patience and guidance.