Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPass forward as R errors commands that generate Redis errors #22
Conversation
… rather than as a text string; addresses #21
Merge remote-tracking branch 'upstream/master' Conflicts: ChangeLog
Merge branch 'master' of github.com:drknexus/rcppredis Conflicts: ChangeLog
| case REDIS_REPLY_ERROR: { | ||
| std::string errorMessage = std::string(reply->str); | ||
| freeReplyObject(reply); | ||
| Rcpp::stop(errorMessage); |
eddelbuettel
Nov 23, 2015
Owner
That is a lot better than what we had!
That is a lot better than what we had!
This comment has been minimized.
This comment has been minimized.
|
Why this commit? I long made it. Are you working a code base that is behind? |
This comment has been minimized.
This comment has been minimized.
|
I was working on the code at the same time you were, then you merged from your local copy of my pull request. For some reason when I rebased on the upstream branch it didn't absorb this commit. In the files changed on the current pull it looks like git correctly sees that you've already applied this change. |
This comment has been minimized.
This comment has been minimized.
|
Gotcha. Truly parallel is an issue. Something And most importantly the PR looked very clean in its diff. Who care about a commit count :) |
Pass forward as R errors commands that generate Redis errors
eddelbuettel
merged commit 3f98a5c
into
eddelbuettel:master
Notably this will pass forward errors for any code that uses extract_reply. In particular, I was trying to address #21, which is in specific regards to exec and execv. Many functions in RcppRedis use extract_reply. However, I do not thing this change should affect them much as they are mostly protected by variable typing in their calls.