New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/embed hiredis #36

Merged
merged 3 commits into from Oct 22, 2018

Conversation

Projects
None yet
2 participants
@eddelbuettel
Owner

eddelbuettel commented Oct 21, 2018

@armstrtw If you have a moment at work on Monday, look this over -- should be fine

I finally gave up on CRAN's ability to eventually procure a libhiredis where it hadn't yet -- ie macOS -- so I stuck in here as a fallback. On normal systems we still use an external hiredis.

Also made RcppMsgPack unconditional at the C++ side as the package already pulled it in.

@armstrtw

This comment has been minimized.

Contributor

armstrtw commented Oct 21, 2018

I'll check it out. Also if you feel like waiting another day or so, I plan to add a few more of the commands for hashes. Sometimes cran seems a bit finicky about accepting multiple releases in a short period.

@eddelbuettel

This comment has been minimized.

Owner

eddelbuettel commented Oct 21, 2018

Sure, just give me a heads-up as you just did, and as we (ahem, ahem, ...) suggest in some Contributing.md (different repo, same idea): issue ticket first is always a good plan so that everybody is on the same page.

Also, if I may, before you branch next let me merge this so that we have clean history graphs.

@eddelbuettel

This comment has been minimized.

Owner

eddelbuettel commented Oct 22, 2018

@armstrtw Did you get a chance to look at it yet?

@armstrtw

This comment has been minimized.

Contributor

armstrtw commented Oct 22, 2018

Sorry for the delay. This compiles/installs and produces expected results for my local scripts. Was there anything in particular that you wanted me to test?

@eddelbuettel eddelbuettel merged commit c11c61b into master Oct 22, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@eddelbuettel eddelbuettel deleted the feature/embed_hiredis branch Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment