Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unlink woes #33

Closed
knapply opened this issue Jul 8, 2020 · 5 comments
Closed

unlink woes #33

knapply opened this issue Jul 8, 2020 · 5 comments

Comments

@knapply
Copy link
Collaborator

@knapply knapply commented Jul 8, 2020

https://twitter.com/michael_chirico/status/1280675491448410113

"just poking around so I may be wrong, but it looks like that unlink should be diagnosis$input[[i]]?"

image

Once upon a time it was only URLs or only files. and unlink() would only affect downloaded files. That's no longer the case.

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Jul 8, 2020

That was too short-hand for me. Maybe copy the tweet text time.

Bugs happen. I created millions in my day. Life goes on. Reasons for 0.1.1 :)

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Jul 8, 2020

Thanks for the edit. I got there eventually. (It doesn't help that Chrome+Twitter, the combo of adblockers I have, don't directly send me to the tweet (high wtf factor here) so I always have to go a send time in incognito mode. Ahh the 1st world problems we have. Now you have know why I whine about directly quoting ;-)

BTW looks like you pushed on "empty" ie "unchanged" branch in issue/33. On purpose?

@knapply
Copy link
Collaborator Author

@knapply knapply commented Jul 8, 2020

Yes, it was intentional.

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Jul 8, 2020

Gotta love a good baseline to compare to :)

knapply added a commit that referenced this issue Jul 8, 2020
fix non-temp file deletion bug
@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Jul 8, 2020

Done in #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.