Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInteger handling #16
Merged
Integer handling #16
Conversation
|
Looks good to me too; checked it out, made a package (under version 0.0.5.1) and tested it. |
|
And as you said: you may as well add ChangeLog and NEWS entry. As maintainer I sometimes tweak these a little so can I also add them -- but a first pass (which may even be final...) would be appreciated. |
|
Feel free to tweak away! |
|
We could have done the tweaking before the merge but six of one, half a dozen of the other. But much smoother ride this time -- I'll just make a quick cleanup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
@eddelbuettel @dcooley - Let's try this again. Addressing #13
If/when all seems well, I'll update
ChangeLog,NEWSbefore merging.