Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integer handling #16

Merged
merged 3 commits into from
May 27, 2020
Merged

Integer handling #16

merged 3 commits into from
May 27, 2020

Conversation

knapply
Copy link
Collaborator

@knapply knapply commented May 26, 2020

@eddelbuettel @dcooley - Let's try this again. Addressing #13

If/when all seems well, I'll update ChangeLog, NEWS before merging.

@dcooley dcooley marked this pull request as ready for review May 26, 2020 20:45
Copy link
Owner

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too; checked it out, made a package (under version 0.0.5.1) and tested it.

@eddelbuettel
Copy link
Owner

And as you said: you may as well add ChangeLog and NEWS entry. As maintainer I sometimes tweak these a little so can I also add them -- but a first pass (which may even be final...) would be appreciated.

@knapply
Copy link
Collaborator Author

knapply commented May 27, 2020

Feel free to tweak away!

@knapply knapply merged commit e8e96ee into master May 27, 2020
@knapply knapply deleted the integer-handling branch May 27, 2020 01:25
@eddelbuettel
Copy link
Owner

We could have done the tweaking before the merge but six of one, half a dozen of the other.

But much smoother ride this time -- I'll just make a quick cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants