Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with upstream 0.4.6 #30

Merged
merged 2 commits into from Jul 3, 2020
Merged

Sync with upstream 0.4.6 #30

merged 2 commits into from Jul 3, 2020

Conversation

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Jul 2, 2020

No description provided.

eddelbuettel added 2 commits Jul 2, 2020
@eddelbuettel eddelbuettel requested a review from knapply Jul 2, 2020
@eddelbuettel
Copy link
Owner Author

@eddelbuettel eddelbuettel commented Jul 2, 2020

@knapply Ok with you fold this in? I can then quickly rebase your the fparse branch too.

@knapply
Copy link
Collaborator

@knapply knapply commented Jul 3, 2020

Thanks, syncing sounds good.

It's been a nutty week work-wise, but I've been trying to squash a bug in the C++ code and finally tracked it down. Will fill you in separately.

@knapply
knapply approved these changes Jul 3, 2020
@eddelbuettel eddelbuettel merged commit d537d10 into master Jul 3, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@eddelbuettel
Copy link
Owner Author

@eddelbuettel eddelbuettel commented Jul 3, 2020

Updated branch feature/fparse with a rebase and force-pushed.

@eddelbuettel eddelbuettel deleted the feature/upstream_sync branch Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.