Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding fparse, fload and more polish #32

Merged
merged 14 commits into from
Jul 7, 2020
Merged

Adding fparse, fload and more polish #32

merged 14 commits into from
Jul 7, 2020

Conversation

eddelbuettel
Copy link
Owner

No description provided.

knapply and others added 13 commits July 4, 2020 12:32
@knapply @eddelbuettel
fparse (user-facing function)
6d53beb
@knapply @eddelbuettel
fix type
ed8f7b8
@knapply @eddelbuettel
DOCKER_CNTR to "rcpp/plus", condition example using bit64, doc fixes,…
6ee7099 
… add fload (user-facing function)
@knapply @eddelbuettel
tweak fparse/fload, clean up their docs, and add their tests
166ef32
@knapply
import utils::download.file
a080262
@knapply
remove now-redundant documentation
e493a15
@knapply
add gcc-7 guards to prevent matrix crashes, use if-initializers every…
9957d60 
…where possible, add single_null option
@knapply
polish fparse/fload, expand test coverage
0ef9726
@knapply
add gcc-7 to travis
585b758
@knapply
add error_ok options, continue chipping away at test coverage, come t…
a5c8169 
…o terms w/ cpp code formatting being as terrible as the rest of its tools
@knapply
disable tests using download.file, roll DESCRIPTION version and date,…
dc15399 
… update NEWS and ChangeLog
@eddelbuettel
tweaks to changelog, news and description
b508118
@knapply
add reusable scalar-arg-checkers (fixes windows failures)
0731486
eddelbuettel
eddelbuettel commented Jul 6, 2020
View reviewed changes
Copy link
Owner Author

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rockin! Apparently I can't approve this as I am listed as the PR author 🙄

@knapply
Copy link
Collaborator

knapply commented Jul 6, 2020 •
edited

Windows success: https://builder.r-hub.io/status/RcppSimdJson_0.0.6.4.tar.gz-f6959dcc7db5abb5e35717c3ed3299d1

Give me a few. I may have a fix for the CRAN Mac.

It throws a fit over std::optional so it's exaggerating it's c++-17-ness pretty hard, but I think I can grab it from <experimental/optional>.

If I can't fix it, how do you feel about initaiting option #ifdef DEAD_MEAT on that system?

@eddelbuettel
Copy link
Owner Author

I really like #if defined(DEADMEAT) as a general fsck you for systems where we have no hope whatsover (hello, Solaris, no need to blush here...) but would prefer to avoid it if we can. Just because so many other devs use crapOS it would be sad to exclude them, especially now that we have windoze covered.

@knapply
Copy link
Collaborator

knapply commented Jul 6, 2020 •
edited

Winner for Mac: https://builder.r-hub.io/status/RcppSimdJson_0.0.6.4.tar.gz-db5eb4365e08415bc961fc1dc52ac2a4

Just checking I'm not breaking anything elsewhere and making the code formatting less... "weak" 🤨

@knapply knapply merged commit 1217e94 into master Jul 7, 2020
@eddelbuettel eddelbuettel deleted the feature/fparse branch July 8, 2020 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knapply knapply knapply approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eddelbuettel @knapply