Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix non-temp file deletion bug #34

Merged
merged 2 commits into from
Jul 8, 2020
Merged

fix non-temp file deletion bug #34

merged 2 commits into from
Jul 8, 2020

Conversation

knapply
Copy link
Collaborator

@knapply knapply commented Jul 8, 2020

Addressing #33

... the formatting change didn't quite stick from the looks of it, but that should be ironed out.

@knapply
Copy link
Collaborator Author

knapply commented Jul 8, 2020

This is also as good a time as any to confirm CRAN plays along with downloading a file.

@knapply knapply requested a review from eddelbuettel July 8, 2020 02:43
Copy link
Owner

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Had to turn 'ignore whitespace' on. Not a biggie though.

@knapply
Copy link
Collaborator Author

knapply commented Jul 8, 2020

I must've checked off that box after formatting the file or something.

Fortunately, the bug only bites if you're reading from both local/remote files simultaneously, but gnarly nonetheless!

@knapply knapply merged commit e11da5e into master Jul 8, 2020
@knapply knapply deleted the issues/33 branch July 8, 2020 16:18
@eddelbuettel eddelbuettel mentioned this pull request Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants