Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to simdjson 0.5.0 #49

Merged
merged 5 commits into from
Oct 7, 2020
Merged

update to simdjson 0.5.0 #49

merged 5 commits into from
Oct 7, 2020

Conversation

eddelbuettel
Copy link
Owner

Better late than never :)

@knapply lemme know what you think. This isn't urgent as I have been, ahem, sitting on this for a few weeks but (coughs twice) beginning of term, this, that, the other and general "it's friggin 2020" madness appear to have gotten in the way :)

Copy link
Collaborator

@knapply knapply left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome to me. 🔥

I'm not seeing any commented-out tests. Are they all running again? If so, 🔥🚀

@eddelbuettel
Copy link
Owner Author

I'm not seeing any commented-out tests.

Yes, I followed up on this today with a PR that just turned them from expect_error() to expect_identical() with the results they now give -- see 5330193 for details if curious.

@eddelbuettel eddelbuettel merged commit bef0257 into master Oct 7, 2020
@eddelbuettel eddelbuettel deleted the feature/simdjson-0.5.0 branch October 24, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants