Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upupdate to simdjson 0.5.0 #49
Merged
Conversation
|
Looks awesome to me. I'm not seeing any commented-out tests. Are they all running again? If so, |
Yes, I followed up on this today with a PR that just turned them from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Better late than never :)
@knapply lemme know what you think. This isn't urgent as I have been, ahem, sitting on this for a few weeks but (coughs twice) beginning of term, this, that, the other and general "it's friggin 2020" madness appear to have gotten in the way :)