New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/includize #21

Merged
merged 4 commits into from Nov 14, 2017

Conversation

Projects
None yet
2 participants
@eddelbuettel
Owner

eddelbuettel commented Nov 14, 2017

Work in progress. Still contains

  • bug in includize headers,
  • missing #define for codecvt which we only get from g++ 5 onwards
@codecov-io

This comment has been minimized.

codecov-io commented Nov 14, 2017

Codecov Report

Merging #21 into master will decrease coverage by 4.93%.
The diff coverage is 63.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   66.66%   61.73%   -4.94%     
==========================================
  Files           2        6       +4     
  Lines          18     1325    +1307     
==========================================
+ Hits           12      818     +806     
- Misses          6      507     +501
Impacted Files Coverage Δ
src/parse.cpp 59.9% <100%> (ø)
inst/include/toml.hpp 42.85% <42.85%> (ø)
inst/include/includize.hpp 63.26% <63.26%> (ø)
inst/include/cpptoml.h 61.96% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0174758...3a4968e. Read the comment docs.

@eddelbuettel

This comment has been minimized.

Owner

eddelbuettel commented Nov 14, 2017

Merging even though work in progress. Will clean up with next ones...

@eddelbuettel eddelbuettel merged commit 54e5e76 into master Nov 14, 2017

2 of 4 checks passed

codecov/patch 63.05% of diff hit (target 66.66%)
Details
codecov/project 61.73% (-4.94%) compared to 0174758
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@eddelbuettel eddelbuettel deleted the feature/includize branch Nov 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment