Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagate escape switch to all calls of getTable() and getArray() #32

merged 1 commit into from Jan 26, 2019


None yet
2 participants
Copy link

commented Jan 26, 2019

I realized I did not fix #26 completely in #27. The issue reappears in cases where there are line breaks and company in arrays, tables etc...

This should close it completely I believe.

I did run tests in ./tests manually and it seemed ok. I may add some more tests focused on this issue if needed.


This comment has been minimized.

Copy link

commented Jan 26, 2019

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is 85.71%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #32   +/-   ##
  Coverage    60.2%   60.2%           
  Files           3       3           
  Lines        1342    1342           
  Hits          808     808           
  Misses        534     534
Impacted Files Coverage Δ
src/parse.cpp 64.62% <85.71%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea9977e...bf483a1. Read the comment docs.


This comment has been minimized.

Copy link

commented Jan 26, 2019

Thank you!

@eddelbuettel eddelbuettel merged commit fafd8a3 into eddelbuettel:master Jan 26, 2019

3 checks passed

codecov/patch 85.71% of diff hit (target 60.2%)
codecov/project 60.2% (+0%) compared to ea9977e
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.