Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #28 again (declare UTF-8 in arrays of strings) #36

Merged
merged 1 commit into from Jun 18, 2019

Conversation

Projects
None yet
2 participants
@vh-d
Copy link
Contributor

commented Jun 18, 2019

This should be the last piece to fix #28. The fixes in #30 did not address strings in arrays.

@codecov

This comment has been minimized.

Copy link

commented Jun 18, 2019

Codecov Report

Merging #36 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage    60.2%   60.23%   +0.02%     
==========================================
  Files           3        3              
  Lines        1342     1343       +1     
==========================================
+ Hits          808      809       +1     
  Misses        534      534
Impacted Files Coverage Δ
src/parse.cpp 64.78% <100%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d17302f...fe08a5c. Read the comment docs.

@eddelbuettel

This comment has been minimized.

Copy link
Owner

commented Jun 18, 2019

Nice catch.

@eddelbuettel eddelbuettel merged commit c7fb71c into eddelbuettel:master Jun 18, 2019

3 checks passed

codecov/patch 100% of diff hit (target 60.2%)
Details
codecov/project 60.23% (+0.02%) compared to d17302f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.