Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test of unicode support on Windows #39

Merged
merged 1 commit into from Jun 24, 2019

Conversation

Projects
None yet
2 participants
@vh-d
Copy link
Contributor

commented Jun 24, 2019

This should make the test of unicode support pass even on systems without UTF-8. Passes all tests on my Windows 7 system (set to Czech locale).

@vh-d

This comment has been minimized.

Copy link
Contributor Author

commented Jun 24, 2019

There is another solution to this problem: adding an option to pass encoding= argument to parse() function in tinytest::test_package().

I find my solution with explicit hex representation more elegant but that feature for tinytest might be needed in the future anyway.

@codecov

This comment has been minimized.

Copy link

commented Jun 24, 2019

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   59.71%   59.71%           
=======================================
  Files           3        3           
  Lines        1343     1343           
=======================================
  Hits          802      802           
  Misses        541      541

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b18fefb...8a9ecb1. Read the comment docs.

@eddelbuettel

This comment has been minimized.

Copy link
Owner

commented Jun 24, 2019

Nice one -- thanks.

@eddelbuettel eddelbuettel merged commit a6358af into eddelbuettel:master Jun 24, 2019

3 checks passed

codecov/patch Coverage not affected when comparing b18fefb...8a9ecb1
Details
codecov/project 59.71% remains the same compared to b18fefb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vh-d vh-d deleted the vh-d:test_unicode_on_windows branch Jun 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.