Fixes #21

Merged
merged 2 commits into from Feb 8, 2016

Conversation

Projects
None yet
2 participants
@ellert
Contributor

ellert commented Feb 7, 2016

No description provided.

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Feb 7, 2016

Owner

Thanks for the pull request.

Can we have a bit of a motivating discussion about why/where you think you need them?

Owner

eddelbuettel commented Feb 7, 2016

Thanks for the pull request.

Can we have a bit of a motivating discussion about why/where you think you need them?

@ellert

This comment has been minimized.

Show comment
Hide comment
@ellert

ellert Feb 8, 2016

Contributor

I was trying to package R-RInside as an RPM for Fedora. The RPM creation failed because the buildroot path was detected to be present in some of the files being packaged:

+ /usr/lib/rpm/check-buildroot
/home/ellert/rpmbuild/BUILDROOT/R-RInside-0.2.13-1.fc23.x86_64/usr/src/debug/R-RInside-0.2.13/RInside/src/RInsideEnvVars.h:        "R_LIBRARY_DIR","/home/ellert/rpmbuild/BUILDROOT/R-RInside-0.2.13-1.fc23.x86_64/usr/lib64/R/library",
/home/ellert/rpmbuild/BUILDROOT/R-RInside-0.2.13-1.fc23.x86_64/usr/src/debug/R-RInside-0.2.13/RInside/src/RInsideEnvVars.h:        "R_LIBS","/home/ellert/rpmbuild/BUILDROOT/R-RInside-0.2.13-1.fc23.x86_64/usr/lib64/R/library",
/home/ellert/rpmbuild/BUILDROOT/R-RInside-0.2.13-1.fc23.x86_64/usr/src/debug/R-RInside-0.2.13/RInside/src/RInsideEnvVars.h:        "R_PACKAGE_DIR","/home/ellert/rpmbuild/BUILDROOT/R-RInside-0.2.13-1.fc23.x86_64/usr/lib64/R/library/RInside",
Binary file /home/ellert/rpmbuild/BUILDROOT/R-RInside-0.2.13-1.fc23.x86_64/usr/lib64/libRInside.so matches
Binary file /home/ellert/rpmbuild/BUILDROOT/R-RInside-0.2.13-1.fc23.x86_64/usr/lib64/R/library/RInside/libs/RInside.so matches
Found '/home/ellert/rpmbuild/BUILDROOT/R-RInside-0.2.13-1.fc23.x86_64' in installed files; aborting

By filtering out the variables containing the buildroot path the RPM build succeeds.

The missing LDFLAGS is just missing - some of the expected linker flags are not used.

Contributor

ellert commented Feb 8, 2016

I was trying to package R-RInside as an RPM for Fedora. The RPM creation failed because the buildroot path was detected to be present in some of the files being packaged:

+ /usr/lib/rpm/check-buildroot
/home/ellert/rpmbuild/BUILDROOT/R-RInside-0.2.13-1.fc23.x86_64/usr/src/debug/R-RInside-0.2.13/RInside/src/RInsideEnvVars.h:        "R_LIBRARY_DIR","/home/ellert/rpmbuild/BUILDROOT/R-RInside-0.2.13-1.fc23.x86_64/usr/lib64/R/library",
/home/ellert/rpmbuild/BUILDROOT/R-RInside-0.2.13-1.fc23.x86_64/usr/src/debug/R-RInside-0.2.13/RInside/src/RInsideEnvVars.h:        "R_LIBS","/home/ellert/rpmbuild/BUILDROOT/R-RInside-0.2.13-1.fc23.x86_64/usr/lib64/R/library",
/home/ellert/rpmbuild/BUILDROOT/R-RInside-0.2.13-1.fc23.x86_64/usr/src/debug/R-RInside-0.2.13/RInside/src/RInsideEnvVars.h:        "R_PACKAGE_DIR","/home/ellert/rpmbuild/BUILDROOT/R-RInside-0.2.13-1.fc23.x86_64/usr/lib64/R/library/RInside",
Binary file /home/ellert/rpmbuild/BUILDROOT/R-RInside-0.2.13-1.fc23.x86_64/usr/lib64/libRInside.so matches
Binary file /home/ellert/rpmbuild/BUILDROOT/R-RInside-0.2.13-1.fc23.x86_64/usr/lib64/R/library/RInside/libs/RInside.so matches
Found '/home/ellert/rpmbuild/BUILDROOT/R-RInside-0.2.13-1.fc23.x86_64' in installed files; aborting

By filtering out the variables containing the buildroot path the RPM build succeeds.

The missing LDFLAGS is just missing - some of the expected linker flags are not used.

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Feb 8, 2016

Owner

Ok, thanks for the feedback.

I looked first at LDFLAGS which I had thought was going into ALL_LIBS but doesn't so this looks legit -- but we seemingly never needed it over in .deb land.

As for the other ones I was hesitating because that part has not changed in forever but I'll have enough local tests there to see if run-time behaviour were to be be affected. If so I'll report back.

Owner

eddelbuettel commented Feb 8, 2016

Ok, thanks for the feedback.

I looked first at LDFLAGS which I had thought was going into ALL_LIBS but doesn't so this looks legit -- but we seemingly never needed it over in .deb land.

As for the other ones I was hesitating because that part has not changed in forever but I'll have enough local tests there to see if run-time behaviour were to be be affected. If so I'll report back.

eddelbuettel added a commit that referenced this pull request Feb 8, 2016

@eddelbuettel eddelbuettel merged commit c511181 into eddelbuettel:master Feb 8, 2016

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Feb 8, 2016

Owner

All good. The wt/ examples needs another update too (now need to link to with -lboost_system too).

I'll add you to the ChangeLog file with your GH email, ok?

Thanks again for the PR -- appreciate it.

Owner

eddelbuettel commented Feb 8, 2016

All good. The wt/ examples needs another update too (now need to link to with -lboost_system too).

I'll add you to the ChangeLog file with your GH email, ok?

Thanks again for the PR -- appreciate it.

@ellert ellert deleted the ellert:fixes branch Feb 20, 2016

@ellert ellert referenced this pull request in eddelbuettel/littler Feb 21, 2016

Merged

Fixes #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment